Skip to content

refactor(oxlint/lsp): check for FixedContentKind instead of guessing logic #19795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Feb 27, 2026
Merged

refactor(oxlint/lsp): check for FixedContentKind instead of guessing logic #19795

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 6 additions & 17 deletions apps/oxlint/src/lsp/code_actions.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,24 +85,13 @@ pub fn fix_all_text_edit(actions: impl Iterator<Item = LinterCodeAction>) -> Vec
let mut text_edits: Vec<TextEdit> = vec![];

for action in actions {
if action.fixed_content.is_empty() {
continue;
}

// for a real linter fix, we expect at least 3 fixes
if action.fixed_content.len() == 2 {
debug!("Multiple fixes found, but only ignore fixes available");
#[cfg(debug_assertions)]
{
debug_assert!(action.fixed_content[0].message.starts_with("Disable"));
debug_assert!(action.fixed_content[0].message.ends_with("for this line"));
}
continue;
}

// For multiple fixes, we take the first one as a representative fix.
// Applying all possible fixes at once is not possible in this context.
let fixed_content = action.fixed_content.into_iter().next().unwrap();
// Search for the first "real" fix for the rule, and ignore the rest of the fixes for the same rule.
let Some(fixed_content) = action.fixed_content.into_iter().find(|fixed| {
matches!(fixed.lsp_kind, FixedContentKind::LintRule | FixedContentKind::UnusedDirective)
}) else {
continue;
};

// Only safe fixes or suggestions are applied in "fix all" action/command.
if !FixKind::SafeFixOrSuggestion.can_apply(fixed_content.kind) {
Expand Down
Loading