Skip to content

fix(linter/adjacent_overload_signatures): Add missing diagnostics #19780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
camc314 merged 2 commits into from
Feb 27, 2026
+67 −1
Merged

fix(linter/adjacent_overload_signatures): Add missing diagnostics #19780

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e52993f
Add diagnostic info for typescript adjacent_overload_signatures
dosmond Feb 26, 2026
855cc4b
Merge branch 'main' into daniel-fix/linter-adjacent-overload-signatur…
camc314 Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion crates/oxc_linter/src/rules/typescript/adjacent_overload_signatures.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,9 @@ fn adjacent_overload_signatures_diagnostic(
first: Option<Span>,
second: Span,
) -> OxcDiagnostic {
let mut d = OxcDiagnostic::warn(format!("All {fn_name:?} signatures should be adjacent."));
let mut d = OxcDiagnostic::warn(format!("All {fn_name:?} signatures should be adjacent."))
.with_help(format!("Move all {fn_name:?} overload signatures together, placing them consecutively before any other members."))
.with_note("Function overload signatures represent multiple ways a function can be called. Keeping them adjacent makes it easier for developers to understand all available call signatures at a glance.");
if let Some(span) = first {
d = d.and_label(span);
}
Expand Down
64 changes: 64 additions & 0 deletions crates/oxc_linter/src/snapshots/typescript_adjacent_overload_signatures.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ source: crates/oxc_linter/src/tester.rs
· ───
6 │ }
╰────
help: Move all "foo" overload signatures together, placing them consecutively before any other members.
note: Function overload signatures represent multiple ways a function can be called. Keeping them adjacent makes it easier for developers to understand all available call signatures at a glance.

⚠ typescript-eslint(adjacent-overload-signatures): All "foo" signatures should be adjacent.
╭─[adjacent_overload_signatures.tsx:3:18]
Expand All @@ -23,6 +25,8 @@ source: crates/oxc_linter/src/tester.rs
· ───
6 │ foo(a);
╰────
help: Move all "foo" overload signatures together, placing them consecutively before any other members.
note: Function overload signatures represent multiple ways a function can be called. Keeping them adjacent makes it easier for developers to understand all available call signatures at a glance.

⚠ typescript-eslint(adjacent-overload-signatures): All "foo" signatures should be adjacent.
╭─[adjacent_overload_signatures.tsx:2:23]
Expand All @@ -34,6 +38,8 @@ source: crates/oxc_linter/src/tester.rs
5 │ export function foo(sn: string | number) {}
· ───
╰────
help: Move all "foo" overload signatures together, placing them consecutively before any other members.
note: Function overload signatures represent multiple ways a function can be called. Keeping them adjacent makes it easier for developers to understand all available call signatures at a glance.

⚠ typescript-eslint(adjacent-overload-signatures): All "foo" signatures should be adjacent.
╭─[adjacent_overload_signatures.tsx:2:23]
Expand All @@ -45,6 +51,8 @@ source: crates/oxc_linter/src/tester.rs
5 │ export function foo(sn: string | number) {}
· ───
╰────
help: Move all "foo" overload signatures together, placing them consecutively before any other members.
note: Function overload signatures represent multiple ways a function can be called. Keeping them adjacent makes it easier for developers to understand all available call signatures at a glance.

⚠ typescript-eslint(adjacent-overload-signatures): All "foo" signatures should be adjacent.
╭─[adjacent_overload_signatures.tsx:2:16]
Expand All @@ -56,6 +64,8 @@ source: crates/oxc_linter/src/tester.rs
5 │ function foo(sn: string | number) {}
· ───
╰────
help: Move all "foo" overload signatures together, placing them consecutively before any other members.
note: Function overload signatures represent multiple ways a function can be called. Keeping them adjacent makes it easier for developers to understand all available call signatures at a glance.

⚠ typescript-eslint(adjacent-overload-signatures): All "foo" signatures should be adjacent.
╭─[adjacent_overload_signatures.tsx:2:16]
Expand All @@ -67,6 +77,8 @@ source: crates/oxc_linter/src/tester.rs
5 │ function foo(sn: string | number) {}
· ───
╰────
help: Move all "foo" overload signatures together, placing them consecutively before any other members.
note: Function overload signatures represent multiple ways a function can be called. Keeping them adjacent makes it easier for developers to understand all available call signatures at a glance.

⚠ typescript-eslint(adjacent-overload-signatures): All "foo" signatures should be adjacent.
╭─[adjacent_overload_signatures.tsx:2:24]
Expand All @@ -78,6 +90,8 @@ source: crates/oxc_linter/src/tester.rs
5 │ declare function foo(sn: string | number);
· ───
╰────
help: Move all "foo" overload signatures together, placing them consecutively before any other members.
note: Function overload signatures represent multiple ways a function can be called. Keeping them adjacent makes it easier for developers to understand all available call signatures at a glance.

⚠ typescript-eslint(adjacent-overload-signatures): All "foo" signatures should be adjacent.
╭─[adjacent_overload_signatures.tsx:2:24]
Expand All @@ -89,6 +103,8 @@ source: crates/oxc_linter/src/tester.rs
5 │ declare function foo(sn: string | number);
· ───
╰────
help: Move all "foo" overload signatures together, placing them consecutively before any other members.
note: Function overload signatures represent multiple ways a function can be called. Keeping them adjacent makes it easier for developers to understand all available call signatures at a glance.

⚠ typescript-eslint(adjacent-overload-signatures): All "foo" signatures should be adjacent.
╭─[adjacent_overload_signatures.tsx:3:25]
Expand All @@ -101,6 +117,8 @@ source: crates/oxc_linter/src/tester.rs
· ───
7 │ }
╰────
help: Move all "foo" overload signatures together, placing them consecutively before any other members.
note: Function overload signatures represent multiple ways a function can be called. Keeping them adjacent makes it easier for developers to understand all available call signatures at a glance.

⚠ typescript-eslint(adjacent-overload-signatures): All "baz" signatures should be adjacent.
╭─[adjacent_overload_signatures.tsx:5:18]
Expand All @@ -112,6 +130,8 @@ source: crates/oxc_linter/src/tester.rs
· ───
8 │ function baz(sn: string | number): void;
╰────
help: Move all "baz" overload signatures together, placing them consecutively before any other members.
note: Function overload signatures represent multiple ways a function can be called. Keeping them adjacent makes it easier for developers to understand all available call signatures at a glance.

⚠ typescript-eslint(adjacent-overload-signatures): All "foo" signatures should be adjacent.
╭─[adjacent_overload_signatures.tsx:3:25]
Expand All @@ -124,6 +144,8 @@ source: crates/oxc_linter/src/tester.rs
· ───
7 │ }
╰────
help: Move all "foo" overload signatures together, placing them consecutively before any other members.
note: Function overload signatures represent multiple ways a function can be called. Keeping them adjacent makes it easier for developers to understand all available call signatures at a glance.

⚠ typescript-eslint(adjacent-overload-signatures): All "baz" signatures should be adjacent.
╭─[adjacent_overload_signatures.tsx:5:18]
Expand All @@ -135,6 +157,8 @@ source: crates/oxc_linter/src/tester.rs
· ───
8 │ function baz(sn: string | number): void;
╰────
help: Move all "baz" overload signatures together, placing them consecutively before any other members.
note: Function overload signatures represent multiple ways a function can be called. Keeping them adjacent makes it easier for developers to understand all available call signatures at a glance.

⚠ typescript-eslint(adjacent-overload-signatures): All "foo" signatures should be adjacent.
╭─[adjacent_overload_signatures.tsx:3:9]
Expand All @@ -147,6 +171,8 @@ source: crates/oxc_linter/src/tester.rs
· ───
7 │ };
╰────
help: Move all "foo" overload signatures together, placing them consecutively before any other members.
note: Function overload signatures represent multiple ways a function can be called. Keeping them adjacent makes it easier for developers to understand all available call signatures at a glance.

⚠ typescript-eslint(adjacent-overload-signatures): All "foo" signatures should be adjacent.
╭─[adjacent_overload_signatures.tsx:3:10]
Expand All @@ -159,6 +185,8 @@ source: crates/oxc_linter/src/tester.rs
· ───
7 │ };
╰────
help: Move all "foo" overload signatures together, placing them consecutively before any other members.
note: Function overload signatures represent multiple ways a function can be called. Keeping them adjacent makes it easier for developers to understand all available call signatures at a glance.

⚠ typescript-eslint(adjacent-overload-signatures): All "foo" signatures should be adjacent.
╭─[adjacent_overload_signatures.tsx:2:9]
Expand All @@ -170,6 +198,8 @@ source: crates/oxc_linter/src/tester.rs
· ───
5 │ foo(sn: string | number): void;
╰────
help: Move all "foo" overload signatures together, placing them consecutively before any other members.
note: Function overload signatures represent multiple ways a function can be called. Keeping them adjacent makes it easier for developers to understand all available call signatures at a glance.

⚠ typescript-eslint(adjacent-overload-signatures): All "call" signatures should be adjacent.
╭─[adjacent_overload_signatures.tsx:2:9]
Expand All @@ -181,6 +211,8 @@ source: crates/oxc_linter/src/tester.rs
· ──────────────────
5 │ (sn: string | number): void;
╰────
help: Move all "call" overload signatures together, placing them consecutively before any other members.
note: Function overload signatures represent multiple ways a function can be called. Keeping them adjacent makes it easier for developers to understand all available call signatures at a glance.

⚠ typescript-eslint(adjacent-overload-signatures): All "foo" signatures should be adjacent.
╭─[adjacent_overload_signatures.tsx:3:9]
Expand All @@ -193,6 +225,8 @@ source: crates/oxc_linter/src/tester.rs
· ───
7 │ }
╰────
help: Move all "foo" overload signatures together, placing them consecutively before any other members.
note: Function overload signatures represent multiple ways a function can be called. Keeping them adjacent makes it easier for developers to understand all available call signatures at a glance.

⚠ typescript-eslint(adjacent-overload-signatures): All "foo" signatures should be adjacent.
╭─[adjacent_overload_signatures.tsx:3:10]
Expand All @@ -205,6 +239,8 @@ source: crates/oxc_linter/src/tester.rs
· ───
7 │ }
╰────
help: Move all "foo" overload signatures together, placing them consecutively before any other members.
note: Function overload signatures represent multiple ways a function can be called. Keeping them adjacent makes it easier for developers to understand all available call signatures at a glance.

⚠ typescript-eslint(adjacent-overload-signatures): All "foo" signatures should be adjacent.
╭─[adjacent_overload_signatures.tsx:3:9]
Expand All @@ -217,6 +253,8 @@ source: crates/oxc_linter/src/tester.rs
· ───
7 │ }
╰────
help: Move all "foo" overload signatures together, placing them consecutively before any other members.
note: Function overload signatures represent multiple ways a function can be called. Keeping them adjacent makes it easier for developers to understand all available call signatures at a glance.

⚠ typescript-eslint(adjacent-overload-signatures): All "foo" signatures should be adjacent.
╭─[adjacent_overload_signatures.tsx:2:9]
Expand All @@ -228,6 +266,8 @@ source: crates/oxc_linter/src/tester.rs
· ───
5 │ foo(sn: string | number): void;
╰────
help: Move all "foo" overload signatures together, placing them consecutively before any other members.
note: Function overload signatures represent multiple ways a function can be called. Keeping them adjacent makes it easier for developers to understand all available call signatures at a glance.

⚠ typescript-eslint(adjacent-overload-signatures): All "baz" signatures should be adjacent.
╭─[adjacent_overload_signatures.tsx:5:11]
Expand All @@ -239,6 +279,8 @@ source: crates/oxc_linter/src/tester.rs
· ───
8 │ };
╰────
help: Move all "baz" overload signatures together, placing them consecutively before any other members.
note: Function overload signatures represent multiple ways a function can be called. Keeping them adjacent makes it easier for developers to understand all available call signatures at a glance.

⚠ typescript-eslint(adjacent-overload-signatures): All "new" signatures should be adjacent.
╭─[adjacent_overload_signatures.tsx:3:9]
Expand All @@ -251,6 +293,8 @@ source: crates/oxc_linter/src/tester.rs
· ───
7 │ }
╰────
help: Move all "new" overload signatures together, placing them consecutively before any other members.
note: Function overload signatures represent multiple ways a function can be called. Keeping them adjacent makes it easier for developers to understand all available call signatures at a glance.

⚠ typescript-eslint(adjacent-overload-signatures): All "new" signatures should be adjacent.
╭─[adjacent_overload_signatures.tsx:2:9]
Expand All @@ -262,6 +306,8 @@ source: crates/oxc_linter/src/tester.rs
· ───
5 │ bar(): void;
╰────
help: Move all "new" overload signatures together, placing them consecutively before any other members.
note: Function overload signatures represent multiple ways a function can be called. Keeping them adjacent makes it easier for developers to understand all available call signatures at a glance.

⚠ typescript-eslint(adjacent-overload-signatures): All "new" signatures should be adjacent.
╭─[adjacent_overload_signatures.tsx:2:9]
Expand All @@ -276,6 +322,8 @@ source: crates/oxc_linter/src/tester.rs
· ───
7 │ }
╰────
help: Move all "new" overload signatures together, placing them consecutively before any other members.
note: Function overload signatures represent multiple ways a function can be called. Keeping them adjacent makes it easier for developers to understand all available call signatures at a glance.

⚠ typescript-eslint(adjacent-overload-signatures): All "constructor" signatures should be adjacent.
╭─[adjacent_overload_signatures.tsx:3:9]
Expand All @@ -288,6 +336,8 @@ source: crates/oxc_linter/src/tester.rs
· ───────────
7 │ }
╰────
help: Move all "constructor" overload signatures together, placing them consecutively before any other members.
note: Function overload signatures represent multiple ways a function can be called. Keeping them adjacent makes it easier for developers to understand all available call signatures at a glance.

⚠ typescript-eslint(adjacent-overload-signatures): All "foo" signatures should be adjacent.
╭─[adjacent_overload_signatures.tsx:3:9]
Expand All @@ -300,6 +350,8 @@ source: crates/oxc_linter/src/tester.rs
· ───
7 │ }
╰────
help: Move all "foo" overload signatures together, placing them consecutively before any other members.
note: Function overload signatures represent multiple ways a function can be called. Keeping them adjacent makes it easier for developers to understand all available call signatures at a glance.

⚠ typescript-eslint(adjacent-overload-signatures): All "foo" signatures should be adjacent.
╭─[adjacent_overload_signatures.tsx:3:9]
Expand All @@ -312,6 +364,8 @@ source: crates/oxc_linter/src/tester.rs
· ───
7 │ }
╰────
help: Move all "foo" overload signatures together, placing them consecutively before any other members.
note: Function overload signatures represent multiple ways a function can be called. Keeping them adjacent makes it easier for developers to understand all available call signatures at a glance.

⚠ typescript-eslint(adjacent-overload-signatures): All "foo" signatures should be adjacent.
╭─[adjacent_overload_signatures.tsx:4:9]
Expand All @@ -324,6 +378,8 @@ source: crates/oxc_linter/src/tester.rs
· ───
8 │ }
╰────
help: Move all "foo" overload signatures together, placing them consecutively before any other members.
note: Function overload signatures represent multiple ways a function can be called. Keeping them adjacent makes it easier for developers to understand all available call signatures at a glance.

⚠ typescript-eslint(adjacent-overload-signatures): All "constructor" signatures should be adjacent.
╭─[adjacent_overload_signatures.tsx:2:9]
Expand All @@ -335,6 +391,8 @@ source: crates/oxc_linter/src/tester.rs
· ───────────
5 │ constructor(sn: string | number) {}
╰────
help: Move all "constructor" overload signatures together, placing them consecutively before any other members.
note: Function overload signatures represent multiple ways a function can be called. Keeping them adjacent makes it easier for developers to understand all available call signatures at a glance.

⚠ typescript-eslint(adjacent-overload-signatures): All "foo" signatures should be adjacent.
╭─[adjacent_overload_signatures.tsx:2:9]
Expand All @@ -346,6 +404,8 @@ source: crates/oxc_linter/src/tester.rs
· ───
5 │ foo(sn: string | number): void {}
╰────
help: Move all "foo" overload signatures together, placing them consecutively before any other members.
note: Function overload signatures represent multiple ways a function can be called. Keeping them adjacent makes it easier for developers to understand all available call signatures at a glance.

⚠ typescript-eslint(adjacent-overload-signatures): All "static foo" signatures should be adjacent.
╭─[adjacent_overload_signatures.tsx:2:9]
Expand All @@ -357,6 +417,8 @@ source: crates/oxc_linter/src/tester.rs
· ──────────
5 │ static foo(sn: string | number): void {}
╰────
help: Move all "static foo" overload signatures together, placing them consecutively before any other members.
note: Function overload signatures represent multiple ways a function can be called. Keeping them adjacent makes it easier for developers to understand all available call signatures at a glance.

⚠ typescript-eslint(adjacent-overload-signatures): All "#private" signatures should be adjacent.
╭─[adjacent_overload_signatures.tsx:3:9]
Expand All @@ -368,3 +430,5 @@ source: crates/oxc_linter/src/tester.rs
· ──────────
6 │ }
╰────
help: Move all "#private" overload signatures together, placing them consecutively before any other members.
note: Function overload signatures represent multiple ways a function can be called. Keeping them adjacent makes it easier for developers to understand all available call signatures at a glance.
Loading