Skip to content

fix(codegen): remove double indentation for enum inside namespace #19775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Feb 27, 2026
Merged

fix(codegen): remove double indentation for enum inside namespace #19775

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion crates/oxc_codegen/src/gen.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3825,7 +3825,6 @@ impl Gen for TSInterfaceHeritage<'_> {

impl Gen for TSEnumDeclaration<'_> {
fn r#gen(&self, p: &mut Codegen, ctx: Context) {
p.print_indent();
if self.declare {
p.print_str("declare ");
}
Expand Down
3 changes: 3 additions & 0 deletions crates/oxc_codegen/tests/integration/ts.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,9 @@ fn cases() {
test_same("class B {\n\tconstructor(override readonly a: number) {}\n}\n");
test_same("class C extends B {\n\toverride show(): void;\n\toverride hide(): void;\n}\n");
test_same("class D extends B {\n\toverride readonly x: number;\n}\n");
test_same(
"declare namespace ns {\n\tclass Foo {}\n\tenum Bar {}\n\ttype Baz = undefined;\n}\n",
);
test_same("class E {\n\tsubscribe!: string;\n}\n");
test_same("class F {\n\taccessor value!: string;\n}\n");
test_same("export { type as as };\n");
Expand Down
Loading