Skip to content

fix(linter/no-empty-interface): add help messages to missing diagnostics #19769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
camc314 merged 2 commits into from
Feb 26, 2026
Merged

fix(linter/no-empty-interface): add help messages to missing diagnostics #19769

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f107da
fix(linter/no-empty-interface): add help messages to missing diagnostics
dosmond Feb 26, 2026
4df9b9f
Merge branch 'main' into daniel-fix/linter-no-empty-interface-help
camc314 Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion crates/oxc_linter/src/rules/typescript/no_empty_interface.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,16 @@ use crate::{
};

fn no_empty_interface_diagnostic(span: Span) -> OxcDiagnostic {
OxcDiagnostic::warn("an empty interface is equivalent to `{}`").with_label(span)
OxcDiagnostic::warn("an empty interface is equivalent to `{}`")
.with_help(
"Add members to this interface, or use a type alias if it is intentionally empty.",
)
.with_label(span)
}

fn no_empty_interface_extend_diagnostic(span: Span) -> OxcDiagnostic {
OxcDiagnostic::warn("an interface declaring no members is equivalent to its supertype")
.with_help("Remove this interface and use the extended type directly or add members to this interface.")
.with_label(span)
}

Expand Down
12 changes: 12 additions & 0 deletions crates/oxc_linter/src/snapshots/typescript_no_empty_interface.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ source: crates/oxc_linter/src/tester.rs
1 │ interface Foo {}
· ────────────────
╰────
help: Add members to this interface, or use a type alias if it is intentionally empty.

× Expected `{` but found `EOF`
╭─[no_empty_interface.tsx:1:25]
Expand All @@ -20,6 +21,7 @@ source: crates/oxc_linter/src/tester.rs
· ────────────────────────────
7 │
╰────
help: Remove this interface and use the extended type directly or add members to this interface.

⚠ typescript-eslint(no-empty-interface): an interface declaring no members is equivalent to its supertype
╭─[no_empty_interface.tsx:6:13]
Expand All @@ -28,6 +30,7 @@ source: crates/oxc_linter/src/tester.rs
· ────────────────────────────
7 │
╰────
help: Remove this interface and use the extended type directly or add members to this interface.

⚠ typescript-eslint(no-empty-interface): an interface declaring no members is equivalent to its supertype
╭─[no_empty_interface.tsx:6:13]
Expand All @@ -36,6 +39,7 @@ source: crates/oxc_linter/src/tester.rs
· ────────────────────────────
7 │
╰────
help: Remove this interface and use the extended type directly or add members to this interface.

⚠ typescript-eslint(no-empty-interface): an interface declaring no members is equivalent to its supertype
╭─[no_empty_interface.tsx:6:13]
Expand All @@ -44,6 +48,7 @@ source: crates/oxc_linter/src/tester.rs
· ────────────────────────────
7 │
╰────
help: Remove this interface and use the extended type directly or add members to this interface.

⚠ typescript-eslint(no-empty-interface): an interface declaring no members is equivalent to its supertype
╭─[no_empty_interface.tsx:6:13]
Expand All @@ -52,18 +57,21 @@ source: crates/oxc_linter/src/tester.rs
· ────────────────────────────
7 │
╰────
help: Remove this interface and use the extended type directly or add members to this interface.

⚠ typescript-eslint(no-empty-interface): an interface declaring no members is equivalent to its supertype
╭─[no_empty_interface.tsx:1:1]
1 │ interface Foo extends Array<number> {}
· ──────────────────────────────────────
╰────
help: Remove this interface and use the extended type directly or add members to this interface.

⚠ typescript-eslint(no-empty-interface): an interface declaring no members is equivalent to its supertype
╭─[no_empty_interface.tsx:1:1]
1 │ interface Foo extends Array<number | {}> {}
· ───────────────────────────────────────────
╰────
help: Remove this interface and use the extended type directly or add members to this interface.

⚠ typescript-eslint(no-empty-interface): an interface declaring no members is equivalent to its supertype
╭─[no_empty_interface.tsx:5:13]
Expand All @@ -72,6 +80,7 @@ source: crates/oxc_linter/src/tester.rs
· ───────────────────────────────────
6 │
╰────
help: Remove this interface and use the extended type directly or add members to this interface.

⚠ typescript-eslint(no-empty-interface): an interface declaring no members is equivalent to its supertype
╭─[no_empty_interface.tsx:3:13]
Expand All @@ -80,6 +89,7 @@ source: crates/oxc_linter/src/tester.rs
· ──────────────────────────
4 │
╰────
help: Remove this interface and use the extended type directly or add members to this interface.

⚠ typescript-eslint(no-empty-interface): an interface declaring no members is equivalent to its supertype
╭─[no_empty_interface.tsx:2:13]
Expand All @@ -88,6 +98,7 @@ source: crates/oxc_linter/src/tester.rs
· ──────────────────────────────────
3 │
╰────
help: Remove this interface and use the extended type directly or add members to this interface.

⚠ typescript-eslint(no-empty-interface): an interface declaring no members is equivalent to its supertype
╭─[no_empty_interface.tsx:4:22]
Expand All @@ -96,3 +107,4 @@ source: crates/oxc_linter/src/tester.rs
· ────────────────────────────
5 │ }
╰────
help: Remove this interface and use the extended type directly or add members to this interface.
Loading