Skip to content

fix(linter/explicit-module-boundary-types): add help messages to missing diagnostics #19736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
camc314 merged 3 commits into from
Feb 26, 2026
Merged

fix(linter/explicit-module-boundary-types): add help messages to missing diagnostics #19736

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
898e965
Add .with_help() to func_missing_return_type, func_missing_argument_t…
dosmond Feb 26, 2026
e5bc702
Merge branch 'main' into dosmond-fix/typescript-explicit-module-bound…
camc314 Feb 26, 2026
378ab1c
u
camc314 Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions crates/oxc_linter/src/rules/typescript/explicit_module_boundary_types.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,15 +24,23 @@ use crate::{
};

fn func_missing_return_type(fn_span: Span) -> OxcDiagnostic {
OxcDiagnostic::warn("Missing return type on function").with_label(fn_span)
OxcDiagnostic::warn("Missing return type on function")
.with_help("Define an explicit return type for the function.")
.with_label(fn_span)
}

fn func_missing_argument_type(param_span: Span) -> OxcDiagnostic {
OxcDiagnostic::warn("Missing argument type on function").with_label(param_span)
OxcDiagnostic::warn("Missing argument type on function")
.with_help("Define an explicit argument type for each argument.")
.with_label(param_span)
}

fn func_argument_is_explicitly_any(param_span: Span) -> OxcDiagnostic {
OxcDiagnostic::warn("Argument is explicitly typed as `any`").with_label(param_span)
OxcDiagnostic::warn("Argument is explicitly typed as `any`")
.with_help(
"Avoid explicit `any` at module boundaries; prefer `unknown` and narrow before use.",
)
.with_label(param_span)
}

#[derive(Debug, Default, Clone, Deserialize)]
Expand Down
Loading
Loading