Skip to content

refactor(oxfmt): Apply rethrow error for all pool.run() calls#19700

Merged
graphite-app[bot] merged 1 commit intomainfrom
02-25-refactor_oxfmt_apply_rethrow_error_for_all_pool.run_calls
Feb 26, 2026
Merged

refactor(oxfmt): Apply rethrow error for all pool.run() calls#19700
graphite-app[bot] merged 1 commit intomainfrom
02-25-refactor_oxfmt_apply_rethrow_error_for_all_pool.run_calls

Conversation

@leaysgur
Copy link
Member

@leaysgur leaysgur commented Feb 25, 2026

Since everything is called via child_process, let's standardize it.
(Currently, even if the caller doesn't look at it at all.)

Copy link
Member Author

leaysgur commented Feb 25, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-cli Area - CLI A-formatter Area - Formatter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Feb 25, 2026
@autofix-ci autofix-ci bot requested a review from Dunqing as a code owner February 25, 2026 05:41
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 25, 2026

Merging this PR will not alter performance

✅ 48 untouched benchmarks
⏩ 7 skipped benchmarks1


Comparing 02-25-refactor_oxfmt_apply_rethrow_error_for_all_pool.run_calls (717dd35) with 02-25-refactor_formatter_split_print_embed_logic (1dad873)2

Open in CodSpeed

Footnotes

  1. 7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on 02-25-refactor_formatter_split_print_embed_logic (ccf8947) during the generation of this report, so 827fec7 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@leaysgur leaysgur force-pushed the 02-25-refactor_oxfmt_apply_rethrow_error_for_all_pool.run_calls branch from 717dd35 to 1d19661 Compare February 25, 2026 06:28
@leaysgur leaysgur changed the title refactor(oxfmt): Apply rethrow error for all pool.run() calls refactor(oxfmt): Apply rethrow error for all pool.run() calls Feb 25, 2026
@leaysgur leaysgur force-pushed the 02-25-refactor_formatter_split_print_embed_logic branch from 1dad873 to fdbbab7 Compare February 26, 2026 03:39
@leaysgur leaysgur force-pushed the 02-25-refactor_oxfmt_apply_rethrow_error_for_all_pool.run_calls branch from 1d19661 to 87abbe8 Compare February 26, 2026 03:39
@Dunqing Dunqing added the 0-merge Merge with Graphite Merge Queue label Feb 26, 2026
Copy link
Member

Dunqing commented Feb 26, 2026

Merge activity

Since everything is called via `child_process`, let's standardize it.
(Currently, even if the caller doesn't look at it at all.)
@graphite-app graphite-app bot force-pushed the 02-25-refactor_formatter_split_print_embed_logic branch from fdbbab7 to 06983a4 Compare February 26, 2026 05:19
@graphite-app graphite-app bot force-pushed the 02-25-refactor_oxfmt_apply_rethrow_error_for_all_pool.run_calls branch from 87abbe8 to a447840 Compare February 26, 2026 05:19
Base automatically changed from 02-25-refactor_formatter_split_print_embed_logic to main February 26, 2026 05:25
@graphite-app graphite-app bot merged commit a447840 into main Feb 26, 2026
20 checks passed
@graphite-app graphite-app bot deleted the 02-25-refactor_oxfmt_apply_rethrow_error_for_all_pool.run_calls branch February 26, 2026 05:25
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Feb 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-formatter Area - Formatter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants