perf(parser): add #[inline(always)] to finish_next_inner#19694
Closed
overlookmotel wants to merge 1 commit intomainfrom
Closed
perf(parser): add #[inline(always)] to finish_next_inner#19694overlookmotel wants to merge 1 commit intomainfrom
#[inline(always)] to finish_next_inner#19694overlookmotel wants to merge 1 commit intomainfrom
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-parser
Merging this PR will improve performance by 8.57%
Performance Changes
Comparing 
Footnotes
|
graphite-app bot
pushed a commit
that referenced
this pull request
Feb 25, 2026
…9684) Replace const generic param from `finish_next_inner`. ```diff - fn finish_next_inner<const REPLACE_SAME_START: bool>(&mut self, kind: Kind) -> Token { + fn finish_next_inner(&mut self, kind: Kind, mode: FinishTokenMode) -> Token { ``` The function is marked `#[inline(always)]` to ensure that `mode` can be statically known from each call site and acts as a const. The perf improvement (5%-8% on `parser_tokens` benchmarks) surprised me. Turns out it's the result of the `#[inline(always)]` (see #19694 which made that change in isolation). Aside from the perf improvement, it's easier to read, and may reduce compile time a bit (as this function is inlined into many call sites).
overlookmotel
deleted the
om/02-24-perf_parser_add_inline_always_to_finish_next_inner_
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.