test(oxfmt): Add js-in-xxx prettier conformance#19563
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 24, 2026
Merged
Conversation
github-actions
bot
added
A-cli
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
13 tasks
leaysgur
force-pushed
the
02-20-test_oxfmt_add_js-in-xxx_prettier_conformance
branch
2 times, most recently
from
fb777c3 to
0b4bf60
Compare
leaysgur
force-pushed
the
02-20-test_oxfmt_add_js-in-xxx_prettier_conformance
branch
from
0b4bf60 to
75d48b7
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds conformance tests to verify that oxfmt's output matches Prettier's output for Vue files (and prepares infrastructure for other file types). The tests download Prettier's official test fixtures from their repository and compare formatting results between oxfmt and Prettier.
Changes:
- Added a new conformance test suite that compares oxfmt formatting output with Prettier's output for Vue files
- Added a script to download Prettier test fixtures from their repository using degit
- Added degit as a dev dependency to enable downloading fixtures
- Updated .gitignore to exclude downloaded fixtures from version control
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-lock.yaml | Adds degit dependency lock entry |
| apps/oxfmt/test/api/js-in-xxx-conformance.test.ts | New conformance test suite that collects Vue fixtures and compares oxfmt vs prettier formatting with multiple option configurations |
| apps/oxfmt/scripts/download-prettier-fixtures.js | Script to download prettier test fixtures using degit from the prettier repository |
| apps/oxfmt/package.json | Adds download-prettier-fixtures script and degit dev dependency |
| apps/oxfmt/.gitignore | Excludes prettier-fixtures directory from git |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
leaysgur
force-pushed
the
02-18-feat_formatter_oxfmt_support_js-in-vue_partially_
branch
from
291d96b to
7fe1a05
Compare
leaysgur
force-pushed
the
02-20-test_oxfmt_add_js-in-xxx_prettier_conformance
branch
2 times, most recently
from
d6fa641 to
cf1530c
Compare
leaysgur
force-pushed
the
02-18-feat_formatter_oxfmt_support_js-in-vue_partially_
branch
from
7fe1a05 to
3b495e4
Compare
Dunqing
approved these changes
Feb 24, 2026
Member
Merge activity
|
Add conformance test `assert(oxfmt(vueFile) === prettier(vueFile))`. Currently, fixtures are downloaded individually and are not executed in CI. It might have been better to change CI to download prettier's submodules and refer to them?, but for now.
graphite-app bot
pushed a commit
that referenced
this pull request
Feb 24, 2026
### Overview Part of #16608 This PR applies `oxc_formatter` to the js-in-vue section. However, it is not complete and is only applied to the following parts within js-in-vue: - `script` block - and `generic="..."` - `v-for` LHS - `v-slot` In the `script` block, `external_callback` is used like a regular JS file, but it isn't for others. TL;DR: Now you can use sort-imports for Vue files. ### Review points The points I'd like to ask your review are the following: - Addition of `format_node()` to `oxc_formatter` - Made it possible to process any type that implements `Format`, not just `Program` - The implementation of `js-in-vue` fragment was separated as much as possible to avoid impacting existing code - `oxc_formatter` IR to prettier `Doc` ### TODOs - [x] Planning - [x] Implementation - [x] Check benchmark - [x] Check coverage - [x] Understand & refactor - [x] oxfmt: JS side - [x] oxfmt: Rust side - [x] oxfmt: to_doc.rs - [x] oxc_formatter: fragment_format - [x] Check benchmark again - [x] Check coverage again - [x] Check ecosystem-ci - [x] Tests 👉🏻 #19563
graphite-app
bot
force-pushed
the
02-18-feat_formatter_oxfmt_support_js-in-vue_partially_
branch
from
3b495e4 to
035933c
Compare
graphite-app
bot
force-pushed
the
02-20-test_oxfmt_add_js-in-xxx_prettier_conformance
branch
from
cf1530c to
4ce37b0
Compare
Base automatically changed from
02-18-feat_formatter_oxfmt_support_js-in-vue_partially_
to
main
February 24, 2026 10:24
graphite-app
bot
deleted the
02-20-test_oxfmt_add_js-in-xxx_prettier_conformance
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add conformance test
assert(oxfmt(vueFile) === prettier(vueFile)).Currently, fixtures are downloaded individually and are not executed in CI.
It might have been better to change CI to download prettier's submodules and refer to them?, but for now.