Skip to content

perf(linter/plugins): use Oxc tokens in plugins #19498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Feb 24, 2026
+279 −691
Merged

perf(linter/plugins): use Oxc tokens in plugins #19498

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions apps/oxlint/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ oxc_allocator = { workspace = true, features = ["fixed_size"] }
oxc_ast_visit = { workspace = true, features = ["serialize"] }
oxc_data_structures = { workspace = true, features = ["rope"] }
oxc_diagnostics = { workspace = true }
oxc_estree_tokens = { workspace = true }
oxc_language_server = { workspace = true }
oxc_linter = { workspace = true }
oxc_napi = { workspace = true }
Expand Down
16 changes: 15 additions & 1 deletion apps/oxlint/conformance/init.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,23 @@ yarn
# Install `eslint-plugin-react-hooks` dependency
cd packages/eslint-plugin-react-hooks
yarn add eslint-plugin-react-hooks
cd ../..

# @overlookmotel says: @camc314 added the next block to this script, but it doesn't seem to work on my machine.
# Presumably it's because we're using different versions of `yarn`, but I can't track down the problem exactly.
# So I'm commenting it out again for now.

# Ensure `eslint-plugin-react-hooks` can be resolved from the React tests directory.
# In recent React workspace setups this is already satisfied after `yarn`, and forcing
# `yarn add` here can fail with workspace invariant errors.
# if ! node -e "require.resolve('eslint-plugin-react-hooks/package.json')" >/dev/null 2>&1; then
# cd packages/eslint-plugin-react-hooks
# yarn add eslint-plugin-react-hooks
# cd ../..
# fi

# Return to `submodules` directory
cd ../../..
cd ..

###############################################################################
# Stylistic
Expand Down
6 changes: 3 additions & 3 deletions apps/oxlint/conformance/snapshots/eslint.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@
| Status | Count | % |
| ----------- | ----- | ------ |
| Total tests | 33285 | 100.0% |
| Passing | 33005 | 99.2% |
| Passing | 33006 | 99.2% |
| Failing | 0 | 0.0% |
| Skipped | 280 | 0.8% |
| Skipped | 279 | 0.8% |

## Fully Passing Rules

Expand Down Expand Up @@ -275,7 +275,7 @@
- `prefer-named-capture-group` (57 tests)
- `prefer-numeric-literals` (87 tests)
- `prefer-object-has-own` (92 tests) (1 skipped)
- `prefer-object-spread` (87 tests) (3 skipped)
- `prefer-object-spread` (87 tests) (2 skipped)
- `prefer-promise-reject-errors` (65 tests)
- `prefer-reflect` (49 tests)
- `prefer-regex-literals` (251 tests) (3 skipped)
Expand Down
Loading
Loading