feat(linter): add typescript/prefer-string-starts-ends-with rule

apps/oxlint/fixtures/tsgolint/.oxlintrc.json

@@ -43,6 +43,7 @@
     "typescript/prefer-regexp-exec": "error",
     "typescript/prefer-reduce-type-parameter": "error",
     "typescript/prefer-return-this-type": "error",
+    "typescript/prefer-string-starts-ends-with": "error",
     "typescript/promise-function-async": "error",
     "typescript/related-getter-setter-pairs": "error",
     "typescript/require-array-sort-compare": "error",

apps/oxlint/fixtures/tsgolint/prefer-string-starts-ends-with.ts

@@ -0,0 +1,9 @@
+// Examples of incorrect code for prefer-string-starts-ends-with rule
+
+function startsCase(s: string): boolean {
+  return s[0] === 'a';
+}
+
+function endsCase(s: string): boolean {
+  return s.slice(-3) === 'bar';
+}

apps/oxlint/fixtures/tsgolint_rule_options/.oxlintrc.json

@@ -80,6 +80,12 @@
         "onlyInlineLambdas": true
       }
     ],
+    "typescript/prefer-string-starts-ends-with": [
+      "error",
+      {
+        "allowSingleElementEquality": "always"
+      }
+    ],
     "typescript/only-throw-error": [
       "error",
       {

apps/oxlint/fixtures/tsgolint_rule_options/test.ts

@@ -110,6 +110,13 @@ class PreferReadonlyOptionExample {
   }
 }
 
+// Test prefer-string-starts-ends-with with allowSingleElementEquality option
+declare const boundaryText: string;
+// This should NOT error because single element equality is allowed
+const boundaryCharMatch = boundaryText[0] === 'a';
+// This SHOULD error because startsWith is preferred here
+const boundarySliceMatch = boundaryText.slice(0, 3) === 'foo';
+
 // Test only-throw-error with allowRethrowing option
 // When allowRethrowing is false, rethrowing a caught error SHOULD error
 try {

apps/oxlint/src/snapshots/fixtures__tsgolint_--type-aware --silent@oxlint.snap

@@ -6,8 +6,8 @@ arguments: --type-aware --silent
 working directory: fixtures/tsgolint
 ----------
 
-Found 0 warnings and 67 errors.
-Finished in <variable>ms on 54 files with 53 rules using 1 threads.
+Found 0 warnings and 69 errors.
+Finished in <variable>ms on 55 files with 54 rules using 1 threads.
 ----------
 CLI result: LintFoundErrors
 ----------

apps/oxlint/src/snapshots/fixtures__tsgolint_--type-aware -c config-test.json@oxlint.snap

@@ -40,7 +40,7 @@ working directory: fixtures/tsgolint
   help: Remove the debugger statement
 
 Found 2 warnings and 2 errors.
-Finished in <variable>ms on 54 files with 1 rules using 1 threads.
+Finished in <variable>ms on 55 files with 1 rules using 1 threads.
 ----------
 CLI result: LintFoundErrors
 ----------

apps/oxlint/src/snapshots/fixtures__tsgolint_--type-aware test.svelte@oxlint.snap

@@ -16,7 +16,7 @@ working directory: fixtures/tsgolint
   help: Remove the debugger statement
 
 Found 0 warnings and 1 error.
-Finished in <variable>ms on 1 file with 53 rules using 1 threads.
+Finished in <variable>ms on 1 file with 54 rules using 1 threads.
 ----------
 CLI result: LintFoundErrors
 ----------

apps/oxlint/src/snapshots/fixtures__tsgolint_--type-aware@oxlint.snap

@@ -415,6 +415,22 @@ working directory: fixtures/tsgolint
  4 |     this.value = value;
    `----
 
+  x typescript-eslint(prefer-string-starts-ends-with): Use 'String#startsWith' method instead.
+   ,-[prefer-string-starts-ends-with.ts:4:10]
+ 3 | function startsCase(s: string): boolean {
+ 4 |   return s[0] === 'a';
+   :          ^^^^^^^^^^^^
+ 5 | }
+   `----
+
+  x typescript-eslint(prefer-string-starts-ends-with): Use 'String#endsWith' method instead.
+   ,-[prefer-string-starts-ends-with.ts:8:10]
+ 7 | function endsCase(s: string): boolean {
+ 8 |   return s.slice(-3) === 'bar';
+   :          ^^^^^^^^^^^^^^^^^^^^^
+ 9 | }
+   `----
+
   x typescript-eslint(promise-function-async): Functions that return promises must be async.
    ,-[promise-function-async.ts:2:1]
  1 |     declare function fetch(url: string): Promise<Response>;
@@ -526,8 +542,8 @@ working directory: fixtures/tsgolint
    `----
   help: If your function does not access `this`, you can annotate it with `this: void`, or consider using an arrow function instead.
 
-Found 0 warnings and 67 errors.
-Finished in <variable>ms on 54 files with 53 rules using 1 threads.
+Found 0 warnings and 69 errors.
+Finished in <variable>ms on 55 files with 54 rules using 1 threads.
 ----------
 CLI result: LintFoundErrors
 ----------

apps/oxlint/src/snapshots/fixtures__tsgolint_rule_options_--type-aware@oxlint.snap

@@ -88,8 +88,16 @@ working directory: fixtures/tsgolint_rule_options
  108 |   getValue() {
      `----
 
-Found 0 warnings and 10 errors.
-Finished in <variable>ms on 1 file with 12 rules using 1 threads.
+  x typescript-eslint(prefer-string-starts-ends-with): Use 'String#startsWith' method instead.
+     ,-[test.ts:118:28]
+ 117 | // This SHOULD error because startsWith is preferred here
+ 118 | const boundarySliceMatch = boundaryText.slice(0, 3) === 'foo';
+     :                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+ 119 | 
+     `----
+
+Found 0 warnings and 11 errors.
+Finished in <variable>ms on 1 file with 13 rules using 1 threads.
 ----------
 CLI result: LintFoundErrors
 ----------

crates/oxc_linter/src/rules.rs

@@ -300,6 +300,7 @@ pub(crate) mod typescript {
     pub mod prefer_reduce_type_parameter;
     pub mod prefer_regexp_exec;
     pub mod prefer_return_this_type;
+    pub mod prefer_string_starts_ends_with;
     pub mod prefer_ts_expect_error;
     pub mod promise_function_async;
     pub mod related_getter_setter_pairs;