Skip to content

refactor(formatter,oxfmt): Simplify sort_imports options parsing#19418

Merged
graphite-app[bot] merged 1 commit intomainfrom
02-16-refactor_formatter_oxfmt_simplify_sort_imports_options_parsing
Feb 16, 2026
Merged

refactor(formatter,oxfmt): Simplify sort_imports options parsing#19418
graphite-app[bot] merged 1 commit intomainfrom
02-16-refactor_formatter_oxfmt_simplify_sort_imports_options_parsing

Conversation

@leaysgur
Copy link
Member

@leaysgur leaysgur commented Feb 16, 2026

Introduce GroupEntry::parse() to reduce redundants.

@leaysgur leaysgur requested a review from Dunqing as a code owner February 16, 2026 02:26
Copy link
Member Author

leaysgur commented Feb 16, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-cli Area - CLI A-formatter Area - Formatter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Feb 16, 2026
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 16, 2026

Merging this PR will not alter performance

✅ 47 untouched benchmarks
⏩ 3 skipped benchmarks1


Comparing 02-16-refactor_formatter_oxfmt_simplify_sort_imports_options_parsing (1f6119e) with 02-16-feat_formatter_sort_imports_report_invalid_group_name_with_removing_selector_and_modifier_ambiguity (abd9424)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@leaysgur leaysgur force-pushed the 02-16-feat_formatter_sort_imports_report_invalid_group_name_with_removing_selector_and_modifier_ambiguity branch from e8bef6c to a662506 Compare February 16, 2026 03:22
@leaysgur leaysgur force-pushed the 02-16-refactor_formatter_oxfmt_simplify_sort_imports_options_parsing branch 2 times, most recently from 6efd57b to 1789770 Compare February 16, 2026 03:32
@leaysgur leaysgur force-pushed the 02-16-feat_formatter_sort_imports_report_invalid_group_name_with_removing_selector_and_modifier_ambiguity branch from 9198e7b to f5fd083 Compare February 16, 2026 03:32
@leaysgur leaysgur force-pushed the 02-16-refactor_formatter_oxfmt_simplify_sort_imports_options_parsing branch from 1789770 to b36751d Compare February 16, 2026 03:48
@leaysgur leaysgur force-pushed the 02-16-feat_formatter_sort_imports_report_invalid_group_name_with_removing_selector_and_modifier_ambiguity branch from 4635829 to abd9424 Compare February 16, 2026 03:48
@leaysgur leaysgur force-pushed the 02-16-refactor_formatter_oxfmt_simplify_sort_imports_options_parsing branch 2 times, most recently from 1b1e584 to 1f6119e Compare February 16, 2026 03:56
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Feb 16, 2026
@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 16, 2026

Merge activity

)

Introduce `GroupEntry::parse()` to reduce redundants.
@graphite-app graphite-app bot force-pushed the 02-16-feat_formatter_sort_imports_report_invalid_group_name_with_removing_selector_and_modifier_ambiguity branch from abd9424 to 9c34f72 Compare February 16, 2026 05:05
@graphite-app graphite-app bot force-pushed the 02-16-refactor_formatter_oxfmt_simplify_sort_imports_options_parsing branch from 1f6119e to e48e6b2 Compare February 16, 2026 05:05
Base automatically changed from 02-16-feat_formatter_sort_imports_report_invalid_group_name_with_removing_selector_and_modifier_ambiguity to main February 16, 2026 05:11
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Feb 16, 2026
@graphite-app graphite-app bot merged commit e48e6b2 into main Feb 16, 2026
22 checks passed
@graphite-app graphite-app bot deleted the 02-16-refactor_formatter_oxfmt_simplify_sort_imports_options_parsing branch February 16, 2026 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-formatter Area - Formatter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant