-
-
Notifications
You must be signed in to change notification settings - Fork 862
feat(linter): support dynamic configs via CLI arguments #19384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
graphite-app
merged 1 commit into
main
from
c/02-14-feat_linter_support_dynamic_configs_via_cli_arguments
Feb 14, 2026
+118
−24
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
apps/oxlint/test/fixtures/js_config_basic_cli_arg/files/test.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| debugger; | ||
| if (x == 1) { | ||
| } |
8 changes: 8 additions & 0 deletions
8
apps/oxlint/test/fixtures/js_config_basic_cli_arg/my-oxlint-config.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| import { defineConfig } from "#oxlint"; | ||
|
|
||
| export default defineConfig({ | ||
| rules: { | ||
| "no-debugger": "error", | ||
| eqeqeq: "warn", | ||
| }, | ||
| }); |
3 changes: 3 additions & 0 deletions
3
apps/oxlint/test/fixtures/js_config_basic_cli_arg/options.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| { | ||
| "args": ["-c", "my-oxlint-config.ts"] | ||
| } |
29 changes: 29 additions & 0 deletions
29
apps/oxlint/test/fixtures/js_config_basic_cli_arg/output.snap.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| # Exit code | ||
| 1 | ||
|
|
||
| # stdout | ||
| ``` | ||
| x eslint(no-debugger): `debugger` statement is not allowed | ||
| ,-[files/test.js:1:1] | ||
| 1 | debugger; | ||
| : ^^^^^^^^^ | ||
| 2 | if (x == 1) { | ||
| `---- | ||
| help: Remove the debugger statement | ||
|
|
||
| ! eslint(eqeqeq): Expected === and instead saw == | ||
| ,-[files/test.js:2:7] | ||
| 1 | debugger; | ||
| 2 | if (x == 1) { | ||
| : ^^ | ||
| 3 | } | ||
| `---- | ||
| help: Prefer === operator | ||
|
|
||
| Found 1 warning and 1 error. | ||
| Finished in Xms on 1 file with 94 rules using X threads. | ||
| ``` | ||
|
|
||
| # stderr | ||
| ``` | ||
| ``` |
3 changes: 3 additions & 0 deletions
3
apps/oxlint/test/fixtures/js_config_invalid_cli_arg/files/test.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| debugger; | ||
| if (x == 1) { | ||
| } |
9 changes: 9 additions & 0 deletions
9
apps/oxlint/test/fixtures/js_config_invalid_cli_arg/my-oxlint-config.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| import { defineConfig } from "#oxlint"; | ||
|
|
||
| export default defineConfig({ | ||
| // @ts-expect-error - we are testing invalid CLI args, so we need to ignore the type error here | ||
| x: { | ||
| "no-debugger": "error", | ||
| eqeqeq: "warn", | ||
| }, | ||
| }); |
3 changes: 3 additions & 0 deletions
3
apps/oxlint/test/fixtures/js_config_invalid_cli_arg/options.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| { | ||
| "args": ["-c", "my-oxlint-config.ts"] | ||
| } |
14 changes: 14 additions & 0 deletions
14
apps/oxlint/test/fixtures/js_config_invalid_cli_arg/output.snap.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| # Exit code | ||
| 1 | ||
|
|
||
| # stdout | ||
| ``` | ||
| Failed to parse oxlint configuration file. | ||
|
|
||
| x Failed to parse config from <fixture>/my-oxlint-config.ts | ||
| note: unknown field `x`, expected one of `$schema`, `plugins`, `jsPlugins`, `categories`, `rules`, `settings`, `env`, `globals`, `overrides`, `ignorePatterns`, `extends` | ||
| ``` | ||
|
|
||
| # stderr | ||
| ``` | ||
| ``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.