refactor(linter/plugins): move and refactor handling legacy report call forms#19239
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 11, 2026
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-linter
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors Oxlint’s JS plugin error reporting to centralize legacy context.report(...) positional-argument handling in plugins/report.ts, while keeping the modern single-descriptor call path fast.
Changes:
- Moves legacy positional
context.report(node, ...)argument normalization fromcontext.tsintoreport.ts. - Updates
Context#reportto forward any extra positional args to the sharedreport(...)implementation. - Adds/updates inline documentation describing supported legacy call forms.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| apps/oxlint/src-js/plugins/report.ts | Adds legacy positional-args conversion and updates shared report(...) signature to accept extra args. |
| apps/oxlint/src-js/plugins/context.ts | Simplifies context.report by forwarding extra args and removes the old normalization helper. |
camc314
approved these changes
Feb 10, 2026
Member
Author
Merge activity
|
…call forms (#19239) Follow on after #19193. Refactor. That PR introduced support for legacy call styles for `context.report`. Move that implementation into `report.ts`, shorten the code a little, and produce consistent object shapes. Avoid calling `convertLegacyCallArgs` in the common case that `report` is called in the modern way.
graphite-app
bot
force-pushed
the
om/02-10-refactor_linter_plugins_move_and_refactor_handling_legacy_report_call_forms
branch
from
7b19f2c to
f33248d
Compare
graphite-app
bot
deleted the
om/02-10-refactor_linter_plugins_move_and_refactor_handling_legacy_report_call_forms
branch
owjs3901
pushed a commit
to owjs3901/oxc
that referenced
this pull request
Feb 11, 2026
…call forms (oxc-project#19239) Follow on after oxc-project#19193. Refactor. That PR introduced support for legacy call styles for `context.report`. Move that implementation into `report.ts`, shorten the code a little, and produce consistent object shapes. Avoid calling `convertLegacyCallArgs` in the common case that `report` is called in the modern way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow on after #19193. Refactor.
That PR introduced support for legacy call styles for
context.report.Move that implementation into
report.ts, shorten the code a little, and produce consistent object shapes. Avoid callingconvertLegacyCallArgsin the common case thatreportis called in the modern way.