Skip to content

fix(napi): disable mimalloc global allocator on android targets#19214

Merged
Boshen merged 1 commit intomainfrom
c/02-10-fix_napi_disable_mimalloc_global_allocator_on_android_targets
Feb 10, 2026
Merged

fix(napi): disable mimalloc global allocator on android targets#19214
Boshen merged 1 commit intomainfrom
c/02-10-fix_napi_disable_mimalloc_global_allocator_on_android_targets

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Feb 10, 2026

No description provided.

@github-actions github-actions bot added A-parser Area - Parser A-minifier Area - Minifier A-transformer Area - Transformer / Transpiler labels Feb 10, 2026
Copy link
Contributor Author

camc314 commented Feb 10, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-bug Category - Bug label Feb 10, 2026
@camc314 camc314 marked this pull request as ready for review February 10, 2026 10:21
Copilot AI review requested due to automatic review settings February 10, 2026 10:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Disables the mimalloc_safe global allocator on Android targets for the N-API Rust crates, aligning allocator configuration with platform support/compatibility constraints.

Changes:

  • Exclude target_os = "android" from enabling the feature = "allocator" global allocator in napi/transform.
  • Exclude target_os = "android" from enabling the feature = "allocator" global allocator in napi/parser.
  • Exclude target_os = "android" from enabling the feature = "allocator" global allocator in napi/minify.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
napi/transform/src/lib.rs Prevents mimalloc_safe from being selected as the global allocator on Android.
napi/parser/src/lib.rs Prevents mimalloc_safe from being selected as the global allocator on Android.
napi/minify/src/lib.rs Prevents mimalloc_safe from being selected as the global allocator on Android.

@Boshen Boshen merged commit bcd0f64 into main Feb 10, 2026
24 checks passed
@Boshen Boshen deleted the c/02-10-fix_napi_disable_mimalloc_global_allocator_on_android_targets branch February 10, 2026 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-minifier Area - Minifier A-parser Area - Parser A-transformer Area - Transformer / Transpiler C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants