refactor(oxfmt): Insert options.(parser|filepath) on Rust side#19199
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 10, 2026
Merged
Conversation
github-actions
bot
added
A-cli
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
leaysgur
changed the title
options.(parser|filepath) in Rust
leaysgur
force-pushed
the
02-10-refactor_oxfmt_insert_options.parser_filepath_in_rust
branch
from
3ca5682 to
757b365
Compare
This was referenced Feb 10, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors oxfmt’s Rust↔JS boundary for external formatting so that Rust injects parser/filepath into the Prettier options object, reducing JS-side work and simplifying the Rust wrapper callbacks.
Changes:
- Simplify NAPI callback signatures for embedded/file formatting from
(options, parserName, ...)to(options, code). - Move
parser/filepathoption injection into Rust (for both embedded formatting and non-JS/TS file formatting). - Add/relocate tracing spans around external formatter operations.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| apps/oxfmt/src/main_napi.rs | Updates NAPI TypeScript callback types to the new (options, code) signatures. |
| apps/oxfmt/src/core/format.rs | Injects parser and filepath into external_options before invoking the external formatter for non-JS/TS files. |
| apps/oxfmt/src/core/external_formatter.rs | Refactors callback type signatures to take owned Value options and injects parser for embedded formatting in Rust. |
| apps/oxfmt/src-js/libs/apis.ts | Removes JS-side mutation of options.parser/options.filepath; assumes Rust provides them. |
| apps/oxfmt/src-js/index.ts | Updates the Node API wrapper to pass the new callback shapes into the NAPI binding. |
| apps/oxfmt/src-js/cli/worker-proxy.ts | Updates worker-proxy RPC functions to match the new callback signatures/params. |
| apps/oxfmt/src-js/bindings.d.ts | Updates generated typings for format and runCli callback signatures. |
leaysgur
changed the title
options.(parser|filepath) in Rustoptions.(parser|filepath) on Rust side
Dunqing
approved these changes
Feb 10, 2026
Contributor
Merge activity
|
graphite-app
bot
force-pushed
the
02-10-refactor_oxfmt_insert_options.parser_filepath_in_rust
branch
from
757b365 to
d1e3537
Compare
graphite-app
bot
deleted the
02-10-refactor_oxfmt_insert_options.parser_filepath_in_rust
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wrap_xxx()in Rust