Skip to content

refactor(oxlint/lsp): introduce FixedContentKind enum#19113

Merged
graphite-app[bot] merged 1 commit intomainfrom
02-07-refactor_oxlint_lsp_introduce_fixedcontentkind_enum
Feb 9, 2026
Merged

refactor(oxlint/lsp): introduce FixedContentKind enum#19113
graphite-app[bot] merged 1 commit intomainfrom
02-07-refactor_oxlint_lsp_introduce_fixedcontentkind_enum

Conversation

@Sysix
Copy link
Member

@Sysix Sysix commented Feb 7, 2026

No description provided.

Copy link
Member Author

Sysix commented Feb 7, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI labels Feb 7, 2026
@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Feb 7, 2026
@Sysix Sysix force-pushed the 02-07-perf_oxlint_lsp_transform_unused_disable_directive_directly_to_diagnosticreport branch from fc0f04f to fb2aaeb Compare February 7, 2026 18:05
@Sysix Sysix force-pushed the 02-07-refactor_oxlint_lsp_introduce_fixedcontentkind_enum branch from 479e8f4 to 8e4fa49 Compare February 7, 2026 18:05
@Sysix Sysix force-pushed the 02-07-perf_oxlint_lsp_transform_unused_disable_directive_directly_to_diagnosticreport branch from fb2aaeb to 595ad64 Compare February 7, 2026 18:25
@Sysix Sysix force-pushed the 02-07-refactor_oxlint_lsp_introduce_fixedcontentkind_enum branch from 8e4fa49 to 38ef22f Compare February 7, 2026 18:25
@Sysix Sysix force-pushed the 02-07-perf_oxlint_lsp_transform_unused_disable_directive_directly_to_diagnosticreport branch from 595ad64 to 85e4608 Compare February 7, 2026 19:52
@Sysix Sysix force-pushed the 02-07-refactor_oxlint_lsp_introduce_fixedcontentkind_enum branch from 38ef22f to 37e4e2e Compare February 7, 2026 19:52
@Sysix Sysix requested a review from Copilot February 7, 2026 20:05
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the oxlint LSP “fixed content” representation by introducing a FixedContentKind enum and threading it through fix creation so each fix can be tagged with an LSP-specific kind.

Changes:

  • Added a new FixedContentKind enum and stored it on FixedContent as lsp_kind.
  • Updated fix_to_fixed_content to accept and propagate the new kind.
  • Tagged different fix sources (LintRule, ignore-line/section, unused-directive) when building code actions.

@Sysix Sysix marked this pull request as ready for review February 7, 2026 20:09
@Sysix Sysix requested a review from camc314 as a code owner February 7, 2026 20:09
@graphite-app graphite-app bot changed the base branch from 02-07-perf_oxlint_lsp_transform_unused_disable_directive_directly_to_diagnosticreport to graphite-base/19113 February 9, 2026 10:36
@graphite-app graphite-app bot force-pushed the 02-07-refactor_oxlint_lsp_introduce_fixedcontentkind_enum branch from 37e4e2e to 407d5bd Compare February 9, 2026 10:44
@graphite-app graphite-app bot force-pushed the graphite-base/19113 branch from 85e4608 to 18f58bd Compare February 9, 2026 10:44
@graphite-app graphite-app bot changed the base branch from graphite-base/19113 to main February 9, 2026 10:45
@graphite-app graphite-app bot force-pushed the 02-07-refactor_oxlint_lsp_introduce_fixedcontentkind_enum branch from 407d5bd to f895cf9 Compare February 9, 2026 10:45
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Feb 9, 2026
@camc314 camc314 self-assigned this Feb 9, 2026
Copy link
Contributor

camc314 commented Feb 9, 2026

Merge activity

@graphite-app graphite-app bot force-pushed the 02-07-refactor_oxlint_lsp_introduce_fixedcontentkind_enum branch from f895cf9 to d6aba50 Compare February 9, 2026 12:52
@graphite-app graphite-app bot merged commit d6aba50 into main Feb 9, 2026
19 checks passed
@graphite-app graphite-app bot deleted the 02-07-refactor_oxlint_lsp_introduce_fixedcontentkind_enum branch February 9, 2026 12:59
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Feb 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants