refactor(linter/plugins): getMessage return messageId#19105
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 8, 2026
Merged
Conversation
Member
Author
bd38bc5 to
c3d4cf9
Compare
c43e884 to
acb69f1
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors message handling in the JS plugin layer by moving messageId extraction into getMessage, returning both the resolved message and normalized messageId to remove duplicated logic at call sites.
Changes:
- Refactor
getMessageto derivemessageIdfrom the providedDiagnostic/Suggestionand return{ message, messageId }. - Update
report()andgetSuggestions()to destructure{ message, messageId }fromgetMessage. - Remove duplicated
messageIdnormalization logic from the two call sites.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| apps/oxlint/src-js/plugins/report.ts | Updates getMessage to return { message, messageId } and adapts report() to use it. |
| apps/oxlint/src-js/plugins/fix.ts | Adapts suggestion message resolution to the new getMessage return shape. |
c3d4cf9 to
37341ce
Compare
acb69f1 to
5e713aa
Compare
5e713aa to
f076d32
Compare
37341ce to
4483647
Compare
f076d32 to
71c8d86
Compare
4483647 to
c230a53
Compare
Contributor
Merge activity
|
Pure refactor. Remove duplicated code at 2 x call sites for `getMessage`, and move the logic into `getMessage` itself instead.
c230a53 to
28d8882
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Pure refactor. Remove duplicated code at 2 x call sites for
getMessage, and move the logic intogetMessageitself instead.