Skip to content

fix(formatter): fallback to formatting when package.json sorting fails #19097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Feb 8, 2026
Merged

fix(formatter): fallback to formatting when package.json sorting fails #19097

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 8 additions & 10 deletions apps/oxfmt/src/core/format.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,16 +235,14 @@ impl SourceFormatter {
sort_options: Option<&sort_package_json::SortOptions>,
) -> Result<String, OxcDiagnostic> {
let source_text: Cow<'_, str> = if let Some(options) = sort_options {
Cow::Owned(
sort_package_json::sort_package_json_with_options(source_text, options).map_err(
|err| {
OxcDiagnostic::error(format!(
"Failed to sort package.json: {}\n{err}",
path.display()
))
},
)?,
)
match sort_package_json::sort_package_json_with_options(source_text, options) {
Ok(sorted) => Cow::Owned(sorted),
// `sort_package_json` can only handle strictly valid JSON.
// On the other hand, Prettier's `json-stringify` parser is very permissive.
// It can format JSON like input even with unquoted keys or trailing commas.
// Therefore, rather than bailing out due to a sorting failure, we opt to format without sorting.
Err(_) => Cow::Borrowed(source_text),
}
} else {
Cow::Borrowed(source_text)
};
Expand Down
Loading