Skip to content

fix(oxfmt): workaround Node.js ThreadsafeFunction cleanup race condition #18980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Boshen merged 1 commit into from
Feb 5, 2026
Merged

fix(oxfmt): workaround Node.js ThreadsafeFunction cleanup race condition #18980

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions apps/oxfmt/src-js/cli.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,4 +55,13 @@ void (async () => {
// `process.exit()` kills the process immediately and `stdout` may not be flushed before process dies.
// https://nodejs.org/api/process.html#processexitcode
process.exitCode = exitCode!;

// Node.js < 25.4.0 has a race condition with ThreadsafeFunction cleanup that causes
// crashes on large codebases. Add a small delay to allow pending NAPI operations
// to complete before exit. Fixed in Node.js 25.4.0+.
// See: https://github.com/nodejs/node/issues/55706
const [major, minor] = process.versions.node.split(".").map(Number);
if (major < 25 || (major === 25 && minor < 4)) {
setTimeout(() => process.exit(), 50);
}
})();
Loading