Skip to content

test(linter/dynamic-config): test case for jsPlugins in overrides#18855

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/02-02-test_linter_dynamic-config_test_case_for_jsplugins_in_overrides
Feb 2, 2026
Merged

test(linter/dynamic-config): test case for jsPlugins in overrides#18855
graphite-app[bot] merged 1 commit intomainfrom
c/02-02-test_linter_dynamic-config_test_case_for_jsplugins_in_overrides

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Feb 2, 2026

No description provided.

Copy link
Contributor Author

camc314 commented Feb 2, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-test Category - Testing. Code is missing test cases, or a PR is adding them label Feb 2, 2026
@camc314 camc314 marked this pull request as ready for review February 2, 2026 14:34
Copilot AI review requested due to automatic review settings February 2, 2026 14:34
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new oxlint CLI fixture to validate that jsPlugins can be declared inside overrides in oxlint.config.ts and still be applied to matching files.

Changes:

  • Introduces a minimal custom JS plugin fixture rule (no-debugger) used only via overrides.
  • Adds an oxlint.config.ts that loads the plugin via overrides[].jsPlugins and enables the plugin rule.
  • Adds a snapshot and a sample files/test.js that triggers the plugin rule.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
apps/oxlint/test/fixtures/js_config_js_plugins_overrides/plugin.ts Adds a basic custom plugin defining a no-debugger rule used by the fixture.
apps/oxlint/test/fixtures/js_config_js_plugins_overrides/oxlint.config.ts Defines config using overrides[].jsPlugins to load the plugin only for matched files.
apps/oxlint/test/fixtures/js_config_js_plugins_overrides/output.snap.md Snapshot asserting CLI output for the override-loaded plugin rule.
apps/oxlint/test/fixtures/js_config_js_plugins_overrides/files/test.js Test input containing debugger; to trigger the custom rule.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 2, 2026

Merge activity

@graphite-app graphite-app bot force-pushed the c/02-02-fix_linter_dynamic-config_set_externalplugin.config_dir_to_fix_js_plugins_loading branch from 73392da to ecf11e5 Compare February 2, 2026 14:40
@graphite-app graphite-app bot force-pushed the c/02-02-test_linter_dynamic-config_test_case_for_jsplugins_in_overrides branch from dab21a8 to b98a11a Compare February 2, 2026 14:41
@camc314 camc314 requested a review from Copilot February 2, 2026 14:41
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Base automatically changed from c/02-02-fix_linter_dynamic-config_set_externalplugin.config_dir_to_fix_js_plugins_loading to main February 2, 2026 14:46
@graphite-app graphite-app bot merged commit b98a11a into main Feb 2, 2026
26 checks passed
@graphite-app graphite-app bot deleted the c/02-02-test_linter_dynamic-config_test_case_for_jsplugins_in_overrides branch February 2, 2026 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-linter Area - Linter A-linter-plugins Area - Linter JS plugins C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants