test(formatter): add regression test for member chain with rest params#18835
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 2, 2026
Merged
test(formatter): add regression test for member chain with rest params#18835graphite-app[bot] merged 1 commit intomainfrom
graphite-app[bot] merged 1 commit intomainfrom
Conversation
github-actions
bot
added
the
C-test
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a regression test for issue #16177, which involved incorrect formatting of member chains when function expressions contained rest parameters. The fix (already implemented in commit 745bc5d) ensures that functions with rest parameters are not considered "simple", allowing member chains to stay hugged while function parameters break vertically, matching Prettier's behavior.
Changes:
- Adds test input file
issue-16177.tswith a member chain containing a function with rest parameters - Adds test snapshot
issue-16177.ts.snapverifying correct formatting at different print widths
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/oxc_formatter/tests/fixtures/ts/member-chains/issue-16177.ts | Test input demonstrating member chain with function expression that has rest parameters |
| crates/oxc_formatter/tests/fixtures/ts/member-chains/issue-16177.ts.snap | Expected output snapshot showing correct formatting at printWidth 80 (chain breaks) and 100 (chain stays hugged) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Dunqing
force-pushed
the
test/issue-16177
branch
from
63b48f0 to
efeeb8a
Compare
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
leaysgur
approved these changes
Feb 2, 2026
Member
Merge activity
|
#18835) Closes #16177 ## Summary - Adds a regression test for issue #16177 ## Details The issue was that member chains would incorrectly break when a function expression had rest parameters: **Before (incorrect):** ```ts jest .spyOn(Element.prototype, "getBoundingClientRect") .mockImplementation(function (this: Element, ...args) { ``` **After (correct - matches Prettier):** ```ts jest.spyOn(Element.prototype, "getBoundingClientRect").mockImplementation(function ( this: Element, ...args ) { ``` This was fixed by #17354, which ensures the `rest` parameter is not considered "simple", allowing the member chain to stay hugged while function parameters break vertically. 🤖 Generated with [Claude Code](https://claude.ai/code)
graphite-app
bot
force-pushed
the
test/issue-16177
branch
from
efeeb8a to
7d35a6f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16177
Summary
Details
The issue was that member chains would incorrectly break when a function expression had rest parameters:
Before (incorrect):
After (correct - matches Prettier):
This was fixed by #17354, which ensures the
restparameter is not considered "simple", allowing the member chain to stay hugged while function parameters break vertically.🤖 Generated with Claude Code