Skip to content

feat(linter/vscode): run extension when JS configs are detected #18832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Feb 2, 2026
Merged

feat(linter/vscode): run extension when JS configs are detected #18832

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions editors/vscode/client/tools/linter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,8 @@ export default class LinterTool implements ToolInterface {
}

this.allowedToStartServer = configService.vsCodeConfig.requireConfig
? (await workspace.findFiles(`**/.oxlintrc.json`, "**/node_modules/**", 1)).length > 0
? (await workspace.findFiles(`**/{.oxlintrc.json,oxlint.config.ts}`, "**/node_modules/**", 1))
.length > 0
: true;

const restartCommand = commands.registerCommand(OxcCommands.RestartServerLint, async () => {
Expand Down Expand Up @@ -307,7 +308,7 @@ export default class LinterTool implements ToolInterface {
if (!this.allowedToStartServer) {
return {
isEnabled: false,
tooltipText: "no .oxlintrc.json found",
tooltipText: "no oxlint config found",
};
} else if (!enable) {
return {
Expand Down Expand Up @@ -352,7 +353,7 @@ export default class LinterTool implements ToolInterface {
statusBarItemHandler: StatusBarItemHandler,
): void {
const watcher = workspace.createFileSystemWatcher(
"**/.oxlintrc.json",
"**/{.oxlintrc.json,oxlint.config.ts}",
false,
true,
!config.requireConfig,
Expand All @@ -368,7 +369,8 @@ export default class LinterTool implements ToolInterface {
watcher.onDidDelete(async () => {
// only can be called when config.requireConfig
this.allowedToStartServer =
(await workspace.findFiles(`**/.oxlintrc.json`, "**/node_modules/**", 1)).length > 0;
(await workspace.findFiles(`**/{.oxlintrc.json,oxlint.config.ts}`, "**/node_modules/**", 1))
.length > 0;
if (!this.allowedToStartServer) {
this.updateStatusBar(statusBarItemHandler, false);
if (this.client && this.client.isRunning()) {
Expand Down
Loading