Skip to content

Comments

refactor(linter/plugins): remove experimental warning#18771

Merged
graphite-app[bot] merged 1 commit intomainfrom
om/01-31-refactor_linter_plugins_remove_experimental_warning
Jan 31, 2026
Merged

refactor(linter/plugins): remove experimental warning#18771
graphite-app[bot] merged 1 commit intomainfrom
om/01-31-refactor_linter_plugins_remove_experimental_warning

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Jan 31, 2026

As we prepare for alpha release of JS plugins, it feels like we can remove the warning logged to stderr.

WARNING: JS plugins are experimental and not subject to semver.
Breaking changes are possible while JS plugins support is under development.

They do still remain experimental, but I don't think we need to shout that quite as loudly now.

Copy link
Member Author

overlookmotel commented Jan 31, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the experimental warning message that was displayed to stderr when JS plugins were loaded in oxlint. The warning informed users that JS plugins are experimental and not subject to semver. As the team prepares for the alpha release, this warning is being removed to reduce noise while the plugins remain technically experimental.

Changes:

  • Removed the warning code that printed to stderr on first plugin load
  • Updated 66 snapshot test files to reflect the absence of the warning in stderr output

Reviewed changes

Copilot reviewed 64 out of 64 changed files in this pull request and generated no comments.

File Description
crates/oxc_linter/src/config/config_builder.rs Removed the conditional check and eprintln statement (9 lines) that displayed the experimental warning, along with the #[expect(clippy::print_stderr)] attribute
apps/oxlint/test/fixtures/*/output.snap.md (66 files) Updated snapshot tests to remove the expected warning text from stderr sections

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 31, 2026

Merging this PR will not alter performance

✅ 46 untouched benchmarks
⏩ 3 skipped benchmarks1


Comparing om/01-31-refactor_linter_plugins_remove_experimental_warning (a549b21) with main (005910a)2

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (d981978) during the generation of this report, so 005910a was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@overlookmotel overlookmotel force-pushed the om/01-31-refactor_linter_plugins_remove_experimental_warning branch from 6e989e2 to b72e579 Compare January 31, 2026 15:15
@overlookmotel overlookmotel force-pushed the om/01-31-refactor_linter_plugins_remove_unnecessary_debug_assertions branch from e13fa60 to 8374b33 Compare January 31, 2026 15:15
@camc314 camc314 force-pushed the om/01-31-refactor_linter_plugins_remove_unnecessary_debug_assertions branch from 8374b33 to 922d883 Compare January 31, 2026 16:22
@camc314 camc314 force-pushed the om/01-31-refactor_linter_plugins_remove_experimental_warning branch from b72e579 to 5c042fa Compare January 31, 2026 16:22
@graphite-app graphite-app bot force-pushed the om/01-31-refactor_linter_plugins_remove_unnecessary_debug_assertions branch from 922d883 to 85c0c93 Compare January 31, 2026 16:42
@graphite-app graphite-app bot force-pushed the om/01-31-refactor_linter_plugins_remove_experimental_warning branch from 5c042fa to 0d2999d Compare January 31, 2026 16:43
@camc314 camc314 force-pushed the om/01-31-refactor_linter_plugins_remove_experimental_warning branch from 0d2999d to ccdaaaa Compare January 31, 2026 16:46
@camc314 camc314 force-pushed the om/01-31-refactor_linter_plugins_remove_unnecessary_debug_assertions branch from 85c0c93 to 1e160fc Compare January 31, 2026 16:46
@graphite-app graphite-app bot force-pushed the om/01-31-refactor_linter_plugins_remove_unnecessary_debug_assertions branch from 1e160fc to 5a93dfc Compare January 31, 2026 17:00
@graphite-app graphite-app bot force-pushed the om/01-31-refactor_linter_plugins_remove_experimental_warning branch from ccdaaaa to 53b5f18 Compare January 31, 2026 17:00
@connorshea
Copy link
Member

@camc314 can probably split this out of the stack and merge it alone?

@camc314 camc314 changed the base branch from om/01-31-refactor_linter_plugins_remove_unnecessary_debug_assertions to graphite-base/18771 January 31, 2026 17:15
@camc314 camc314 force-pushed the graphite-base/18771 branch from 5a93dfc to d981978 Compare January 31, 2026 17:15
@camc314 camc314 force-pushed the om/01-31-refactor_linter_plugins_remove_experimental_warning branch from 53b5f18 to a549b21 Compare January 31, 2026 17:15
@camc314 camc314 changed the base branch from graphite-base/18771 to main January 31, 2026 17:15
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Jan 31, 2026
Copy link
Contributor

camc314 commented Jan 31, 2026

Merge activity

  • Jan 31, 5:16 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 31, 5:16 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 31, 5:27 PM UTC: camc314 added this pull request to the Graphite merge queue.
  • Jan 31, 5:34 PM UTC: Merged by the Graphite merge queue.

As we prepare for alpha release of JS plugins, it feels like we can remove the warning logged to stderr.

```
WARNING: JS plugins are experimental and not subject to semver.
Breaking changes are possible while JS plugins support is under development.
```

They do still remain experimental, but I don't think we need to shout that quite as loudly now.
@graphite-app graphite-app bot force-pushed the om/01-31-refactor_linter_plugins_remove_experimental_warning branch from a549b21 to 6ad4480 Compare January 31, 2026 17:28
@graphite-app graphite-app bot merged commit 6ad4480 into main Jan 31, 2026
21 checks passed
@graphite-app graphite-app bot deleted the om/01-31-refactor_linter_plugins_remove_experimental_warning branch January 31, 2026 17:34
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jan 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-linter Area - Linter A-linter-plugins Area - Linter JS plugins C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants