refactor(linter): loosen lifetime requirements on RuntimeFileSystem::read_to_arena_str

[overlookmotel]

Follow-on after #17840. After that PR we can loosen the lifetime requirements on RuntimeFileSystem::read_to_arena_str. All implementations now read/copy the source text into Allocator, so &self no longer needs to be &'a self - lifetime of the returned &str depends only on lifetime of the &'a Allocator.

[overlookmotel]

• refactor(linter): loosen lifetime requirements on RuntimeFileSystem::read_to_arena_str #18770 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[camc314]

Merge activity

• Jan 31, 2:09 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Jan 31, 2:10 PM UTC: camc314 added this pull request to the Graphite merge queue.
• Jan 31, 2:16 PM UTC: Merged by the Graphite merge queue.

[Copilot]

Pull request overview

This PR refactors the lifetime requirements on RuntimeFileSystem::read_to_arena_str by removing the constraint that the returned string's lifetime is tied to the RuntimeFileSystem instance. Since all implementations copy the source text into the Allocator, the lifetime of the returned &str only depends on the Allocator, not the file system object.

Changes:

• Changed trait method signature to use &self instead of &'a self
• Updated function parameters that use RuntimeFileSystem to remove unnecessary 'a lifetime constraints
• Applied changes consistently to helper functions and internal methods

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[codspeed-hq]

CodSpeed Performance Report

Merging this PR will not alter performance

_{Comparing om/01-30-refactor_linter_loosen_lifetime_requirements_on_runtimefilesystem_read_to_arena_str_ (8e957b8) with main (358b2c1)¹}

Summary

✅ 46 untouched benchmarks
⏩ 3 skipped benchmarks²

Footnotes

1. No successful run was found on main (772ea70) during the generation of this report, so 358b2c1 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

2. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩