Skip to content

fix(oxlint/lsp): disable JS plugins support in LSP except in tests #18727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Jan 30, 2026
Merged

fix(oxlint/lsp): disable JS plugins support in LSP except in tests #18727

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions apps/oxlint/src/run.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,10 @@ async fn lint_impl(

// If --lsp flag is set, run the language server
if command.lsp {
// Disable JS plugins support except in tests.
// TODO: Remove this line once we have solidified the implementation and thoroughly tested it.
let external_linter = if cfg!(feature = "testing") { external_linter } else { None };

crate::lsp::run_lsp(external_linter).await;
return CliRunResult::LintSucceeded;
}
Expand Down
Loading