Skip to content

fix(linter): no-useless-constructor should allow argument transformation #18706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
camc314 merged 2 commits into from
Jan 29, 2026
Merged

fix(linter): no-useless-constructor should allow argument transformation #18706

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d37b7b
fix(linter): `no-useless-constructor` correctly handles argument tran…
ddmoney420 Jan 29, 2026
8f7e40f
ui
camc314 Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion crates/oxc_linter/src/rules/eslint/no_useless_constructor.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,8 +222,20 @@ fn is_only_simple_params(params: &FormalParameters) -> bool {
&& params.items.iter().all(|param| param.initializer.is_none())
}

/// Check if the super call is just spreading the `arguments` object, i.e., `super(...arguments)`.
///
/// Returns `true` only if there is exactly one spread argument that is the `arguments` identifier.
/// This ensures we don't flag constructors that transform arguments before passing to super,
/// such as `super(...args.map(x => x))`.
fn is_spread_arguments(super_args: &[Argument<'_>]) -> bool {
super_args.len() == 1 && super_args[0].is_spread()
if super_args.len() == 1
&& let Argument::SpreadElement(spread) = &super_args[0]
&& spread.argument.is_specific_id("arguments")
{
return true;
}

false
}

fn is_passing_through<'a>(
Expand Down Expand Up @@ -339,6 +351,13 @@ fn test() {
// }
// }
// ",
// Argument transformation: constructor is not useless when arguments are processed/transformed
// https://github.com/oxc-project/oxc/issues/17469
"class A extends B { constructor(...args) { super(...args.map(x => x)); } }",
"class A extends B { constructor(...args) { super(...args.filter(x => x)); } }",
"class A extends B { constructor(...args) { super(...args.slice(1)); } }",
"class A extends B { constructor(...args) { super(...transform(args)); } }",
"class A extends B { constructor(...args) { super(...[...args, extra]); } }",
];

let pass_typescript = vec![
Expand Down
Loading