refactor(linter/plugins): cwd set per file#18701
Merged
graphite-app[bot] merged 1 commit intoJan 30, 2026
Merged
Conversation
github-actions
Bot
added
A-linter
This was referenced Jan 29, 2026
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
camc314
approved these changes
Jan 29, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the oxlint JS plugin context setup so cwd can be set per file by passing it into setupFileContext, paving the way for workspace isolation work (see #17809).
Changes:
- Update
setupFileContextto accept(filePath, cwd)and clearcwdinresetFileContext. - Update the linter entrypoint (
lintFileImpl) to pass a cwd value intosetupFileContext. - Update affected tests to provide both an absolute file path and a cwd.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| apps/oxlint/test/tokens.test.ts | Updates test setup to pass absolute path and cwd into setupFileContext. |
| apps/oxlint/test/isSpaceBetween.test.ts | Updates parse helper to derive path from cwd + filename and pass cwd into setupFileContext. |
| apps/oxlint/src-js/plugins/lint.ts | Passes cwd into setupFileContext (currently via a module-level constant). |
| apps/oxlint/src-js/plugins/context.ts | Changes setupFileContext signature to accept per-file cwd and updates cwd getters/reset logic. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Merge activity
|
Pass `cwd` into `setupFileContext`, so it can be set per file, rather than being a global setting. This is preamble to #17809. This PR is some of the changes from that one split off, so the diff on #17809 is focused just on that one change. This PR does nothing in itself, as currently `process.cwd()` is always passed to `setupFileContext`.
graphite-app
Bot
force-pushed
the
om/01-29-refactor_linter_plugins_cwd_set_per_file
branch
from
24a259b to
3818486
Compare
graphite-app
Bot
deleted the
om/01-29-refactor_linter_plugins_cwd_set_per_file
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass
cwdintosetupFileContext, so it can be set per file, rather than being a global setting.This is preamble to #17809. This PR is some of the changes from that one split off, so the diff on #17809 is focused just on that one change.
This PR does nothing in itself, as currently
process.cwd()is always passed tosetupFileContext.