Skip to content

fix(formatter): preserve quote for class property key in TypeScript #18692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Jan 29, 2026
Merged

fix(formatter): preserve quote for class property key in TypeScript #18692

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions crates/oxc_formatter/src/utils/object.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,10 @@ use crate::{

pub fn format_property_key<'a>(key: &AstNode<'a, PropertyKey<'a>>, f: &mut Formatter<'_, 'a>) {
if let PropertyKey::StringLiteral(s) = key.as_ref() {
// `"constructor"` property in the class should be kept quoted
// For TypeScript class property declarations, quotes should always be preserved.
// https://github.com/prettier/prettier/issues/4516
let kind = if matches!(key.parent(), AstNodes::PropertyDefinition(_))
&& matches!(key.as_ref(), PropertyKey::StringLiteral(string) if string.value == "constructor")
&& f.context().source_type().is_typescript()
{
StringLiteralParentKind::Expression
} else {
Expand Down
3 changes: 1 addition & 2 deletions tasks/prettier_conformance/snapshots/prettier.ts.snap.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ts compatibility: 588/601 (97.84%)
ts compatibility: 589/601 (98.00%)

# Failed

Expand All @@ -8,7 +8,6 @@ ts compatibility: 588/601 (97.84%)
| typescript/arrow/comments/issue-11100.ts | 💥 | 84.00% |
| typescript/as/break-after-keyword/18148.ts | 💥 | 82.22% |
| typescript/class/empty-method-body.ts | 💥 | 80.00% |
| typescript/class/quoted-property.ts | 💥 | 66.67% |
| typescript/comments/mapped_types.ts | 💥 | 96.77% |
| typescript/comments/method_types.ts | 💥 | 82.05% |
| typescript/last-argument-expansion/decorated-function.tsx | 💥 | 29.06% |
Expand Down
Loading