Skip to content

Comments

refactor(linter): rename DEFAULT_OXLINTRC to `DEFAULT_OXLINTRC_NAME#18666

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/01-28-refactor_linter_rename_default_oxlintrc_to_default_oxlintrc_name
Jan 28, 2026
Merged

refactor(linter): rename DEFAULT_OXLINTRC to `DEFAULT_OXLINTRC_NAME#18666
graphite-app[bot] merged 1 commit intomainfrom
c/01-28-refactor_linter_rename_default_oxlintrc_to_default_oxlintrc_name

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Jan 28, 2026

No description provided.

Copy link
Contributor Author

camc314 commented Jan 28, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camc314 camc314 marked this pull request as ready for review January 28, 2026 14:36
Copilot AI review requested due to automatic review settings January 28, 2026 14:36
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR consistently renames the default oxlint configuration file constant from DEFAULT_OXLINTRC to DEFAULT_OXLINTRC_NAME across the CLI, LSP, and tests to better reflect its semantics as a filename.

Changes:

  • Renamed the constant in lib.rs to DEFAULT_OXLINTRC_NAME while keeping its value .oxlintrc.json unchanged.
  • Updated all usages of the constant in CLI init logic, LSP server configuration resolution, and config walker to reference DEFAULT_OXLINTRC_NAME.
  • Adjusted tests in lint.rs to use DEFAULT_OXLINTRC_NAME to ensure configuration initialization behavior remains covered.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
apps/oxlint/src/lib.rs Renames the default config filename constant to DEFAULT_OXLINTRC_NAME, establishing the new identifier.
apps/oxlint/src/mode/init.rs Uses DEFAULT_OXLINTRC_NAME when writing the default configuration file during --init.
apps/oxlint/src/lsp/server_linter.rs Switches LSP default config path handling to use DEFAULT_OXLINTRC_NAME.
apps/oxlint/src/lsp/config_walker.rs Updates config discovery to compare filenames against DEFAULT_OXLINTRC_NAME.
apps/oxlint/src/lint.rs Uses DEFAULT_OXLINTRC_NAME in config lookup logic and associated tests, keeping behavior intact.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@graphite-app
Copy link
Contributor

graphite-app bot commented Jan 28, 2026

Merge activity

@graphite-app graphite-app bot force-pushed the c/01-28-refactor_linter_rename_default_oxlintrc_to_default_oxlintrc_name branch from 122aff7 to 25a2416 Compare January 28, 2026 14:43
@graphite-app graphite-app bot merged commit 25a2416 into main Jan 28, 2026
20 checks passed
@graphite-app graphite-app bot deleted the c/01-28-refactor_linter_rename_default_oxlintrc_to_default_oxlintrc_name branch January 28, 2026 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant