Skip to content

test(linter/plugins): add eslint-plugin-sonarjs to conformance tests #18646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Jan 28, 2026
+2,222 −3
Merged

test(linter/plugins): add eslint-plugin-sonarjs to conformance tests #18646

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 47 additions & 0 deletions apps/oxlint/conformance/init.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ set -e
ESLINT_SHA="8f360ad6a7a743d33a83eed8973ee4a50731e55b" # 10.0.0-rc.0
REACT_SHA="612e371fb215498edde4c853bd1e0c8e9203808f" # 19.2.3
STYLISTIC_SHA="5c4b512a225a314fa5f41eead9fdc4d51fc243d7" # 5.7.1
SONAR_SHA="8852e2593390e00f9d9aea764b0b0b9a503d1f08" # 3.0.6

# Shallow clone a repo at a specific commit.
# Git commands copied from `.github/scripts/clone-parallel.mjs`.
Expand Down Expand Up @@ -120,3 +121,49 @@ EOF

# Return to `submodules` directory
cd ..

###############################################################################
# SonarJS
###############################################################################

# Clone SonarJS repo into `submodules/sonarjs`
clone sonarjs https://github.com/SonarSource/SonarJS.git "$SONAR_SHA"

# Install dependencies
pnpm install --ignore-workspace

# Build
# (ignore errors, it's just typecheck fail)
pnpm run bbf || true

# The tests use `describe` and `it` from `node:test`, but we just need to use global `describe`,
# and make `it` behave like `describe`
PATTERN="s/import .* from 'node:test';/const it = describe;/"
if [[ "$OSTYPE" == darwin* ]]; then
find packages/jsts/src/rules -name '*.test.ts' -exec sed -i '' "$PATTERN" {} \;
else
find packages/jsts/src/rules -name '*.test.ts' -exec sed -i "$PATTERN" {} \;
fi

# Replace `import.meta.dirname` with `__dirname` (`import.meta.dirname` doesn't work after `tsx` transforms to CommonJS)
PATTERN2="s/import\.meta\.dirname/__dirname/g"
TESTER_PATH="packages/jsts/tests/tools/testers/rule-tester.ts"
if [[ "$OSTYPE" == darwin* ]]; then
find packages/jsts/src/rules -name '*.test.ts' -exec sed -i '' "$PATTERN2" {} \;
sed -i '' "$PATTERN2" "$TESTER_PATH"
else
find packages/jsts/src/rules -name '*.test.ts' -exec sed -i "$PATTERN2" {} \;
sed -i "$PATTERN2" "$TESTER_PATH"
fi

# Replace `import { it } from 'node:test';` with `const it = describe;` in comment-based checker
PATTERN3="s/import .* from 'node:test';/const it = describe;/"
CHECKER_PATH="packages/jsts/tests/tools/testers/comment-based/checker.ts"
if [[ "$OSTYPE" == darwin* ]]; then
sed -i '' "$PATTERN3" "$CHECKER_PATH"
else
sed -i "$PATTERN3" "$CHECKER_PATH"
fi

# Return to `submodules` directory
cd ..
Loading
Loading