Skip to content

refactor(linter): move consistent-test-it rule to shared and crate own rule for vitest #18605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sysix wants to merge 1 commit into
base: 01-23-refactor_linter_move_valid-title_rule_to_shared_and_crate_own_rule_for_vitest_
Choose a base branch
from
Open

refactor(linter): move consistent-test-it rule to shared and crate own rule for vitest #18605

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion crates/oxc_linter/data/vitest_compatible_jest_rules.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
[
"consistent-test-it",
"expect-expect",
"max-expects",
"max-nested-describe",
Expand Down
5 changes: 5 additions & 0 deletions crates/oxc_linter/src/generated/rule_runner_impls.rs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

26 changes: 25 additions & 1 deletion crates/oxc_linter/src/generated/rules_enum.rs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions crates/oxc_linter/src/rules.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -703,6 +703,7 @@ pub(crate) mod promise {
pub(crate) mod vitest {
pub mod consistent_each_for;
pub mod consistent_test_filename;
pub mod consistent_test_it;
pub mod consistent_vitest_vi;
pub mod hoisted_apis_on_top;
pub mod no_conditional_tests;
Expand Down Expand Up @@ -751,6 +752,7 @@ pub(crate) mod vue {
}

pub(crate) mod shared {
pub mod consistent_test_it;
pub mod valid_title;
}

Expand Down
Loading
Loading