Skip to content

refactor(linter): update type references for lazy-loaded functions#18600

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/01-26-refactor_linter_update_type_references_for_lazy-loaded_functions
Jan 27, 2026
Merged

refactor(linter): update type references for lazy-loaded functions#18600
graphite-app[bot] merged 1 commit intomainfrom
c/01-26-refactor_linter_update_type_references_for_lazy-loaded_functions

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Jan 26, 2026

this just makes the editor experience slightly nicer as you can click through things without being in the loop of the wrapper functions

@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI A-linter-plugins Area - Linter JS plugins C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Jan 26, 2026
Copy link
Contributor Author

camc314 commented Jan 26, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camc314 camc314 marked this pull request as ready for review January 26, 2026 20:13
Copilot AI review requested due to automatic review settings January 26, 2026 20:13
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors type annotations for lazy-loaded plugin functions to directly reference the actual implementations instead of wrapper functions, improving the IDE navigation experience.

Changes:

  • Updated type annotations for loadPlugin, setupRuleConfigs, and lintFile variables to use typeof import() syntax that references the actual function exports from ./plugins/index.ts instead of the wrapper function types

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@camc314 camc314 force-pushed the c/01-26-refactor_linter_update_type_references_for_lazy-loaded_functions branch from 7e69580 to 32fbe3d Compare January 26, 2026 20:29
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Jan 27, 2026
Copy link
Member

overlookmotel commented Jan 27, 2026

Merge activity

…18600)

this just makes the editor experience slightly nicer as you can click through things without being in the loop of the wrapper functions
@graphite-app graphite-app bot force-pushed the c/01-26-refactor_linter_update_type_references_for_lazy-loaded_functions branch from 32fbe3d to b1c5f35 Compare January 27, 2026 00:30
@graphite-app graphite-app bot merged commit b1c5f35 into main Jan 27, 2026
19 checks passed
@graphite-app graphite-app bot deleted the c/01-26-refactor_linter_update_type_references_for_lazy-loaded_functions branch January 27, 2026 00:36
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-linter Area - Linter A-linter-plugins Area - Linter JS plugins C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants