refactor(linter): share edit-distance typo matching#18544
Merged
graphite-app[bot] merged 1 commit intomainfrom Jan 25, 2026
Merged
Conversation
github-actions
bot
added
A-linter
This was referenced Jan 25, 2026
Contributor
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Base automatically changed from
01-25-feat_linter_valid-typeof_add_suggestions_if_type_is_misspelled
to
main
January 25, 2026 19:28
camchenry
approved these changes
Jan 25, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors typo-matching logic by extracting a shared edit-distance utility that can be reused across multiple linter rules. The change improves code maintainability by eliminating duplicated logic.
Changes:
- Introduces a new
edit_distanceutility module with Levenshtein distance calculation and best-match finding - Refactors
nextjs/no_typosto use the shared utility instead of local implementation - Refactors
eslint/valid_typeofto use edit distance matching instead of hardcoded typo patterns
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| crates/oxc_linter/src/utils/mod.rs | Adds module declaration and exports for the new edit_distance utility |
| crates/oxc_linter/src/utils/edit_distance.rs | New utility module providing min_edit_distance and best_match functions for typo detection |
| crates/oxc_linter/src/rules/nextjs/no_typos.rs | Replaces local edit distance implementation with shared utility |
| crates/oxc_linter/src/rules/eslint/valid_typeof.rs | Replaces hardcoded typo patterns with edit distance matching (threshold=2) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Merge activity
|
graphite-app
bot
force-pushed
the
c/01-25-refactor_linter_share_edit-distance_typo_matching
branch
from
b4279f4 to
59e5de5
Compare
graphite-app
bot
deleted the
c/01-25-refactor_linter_share_edit-distance_typo_matching
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.