Skip to content

feat(semantic): add TS1053 code to diagnostic #18539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Jan 25, 2026
+7 −7
Merged

feat(semantic): add TS1053 code to diagnostic #18539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/oxc_parser/src/diagnostics.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1133,7 +1133,7 @@ pub fn setter_with_parameters(span: Span, parameters_count: usize) -> OxcDiagnos

#[cold]
pub fn setter_with_rest_parameter(span: Span) -> OxcDiagnostic {
OxcDiagnostic::error("A 'set' accessor cannot have rest parameter.").with_label(span)
ts_error("1053", "A 'set' accessor cannot have rest parameter.").with_label(span)
}
#[cold]
pub fn setter_with_initializer(span: Span) -> OxcDiagnostic {
Expand Down
6 changes: 3 additions & 3 deletions tasks/coverage/snapshots/parser_babel.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11997,7 +11997,7 @@ Expect to Parse: tasks/coverage/babel/packages/babel-parser/test/fixtures/typesc
· ──────
╰────

× A 'set' accessor cannot have rest parameter.
× TS(1053): A 'set' accessor cannot have rest parameter.
╭─[babel/packages/babel-parser/test/fixtures/esprima/rest-parameter/invalid-setter-rest/input.js:1:13]
1 │ x = { set f(...y) {} }
· ────
Expand Down Expand Up @@ -13305,7 +13305,7 @@ Expect to Parse: tasks/coverage/babel/packages/babel-parser/test/fixtures/typesc
╰────
help: Add a parameter here

× A 'set' accessor cannot have rest parameter.
× TS(1053): A 'set' accessor cannot have rest parameter.
╭─[babel/packages/babel-parser/test/fixtures/typescript/interface/get-set-invalid-reset-parameter/input.ts:2:11]
1 │ interface Foo {
2 │ set bar(...v);
Expand All @@ -13322,7 +13322,7 @@ Expect to Parse: tasks/coverage/babel/packages/babel-parser/test/fixtures/typesc
╰────
help: Add a parameter here

× A 'set' accessor cannot have rest parameter.
× TS(1053): A 'set' accessor cannot have rest parameter.
╭─[babel/packages/babel-parser/test/fixtures/typescript/interface/get-set-invalid-reset-parameter-babel-7/input.ts:2:11]
1 │ interface Foo {
2 │ set bar(...v);
Expand Down
6 changes: 3 additions & 3 deletions tasks/coverage/snapshots/parser_typescript.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2494,15 +2494,15 @@ Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/statements/Va
4 │ }
╰────

× A 'set' accessor cannot have rest parameter.
× TS(1053): A 'set' accessor cannot have rest parameter.
╭─[typescript/tests/cases/compiler/accessorWithRestParam.ts:2:11]
1 │ class C {
2 │ set X(...v) { }
· ────
3 │ static set X(...v2) { }
╰────

× A 'set' accessor cannot have rest parameter.
× TS(1053): A 'set' accessor cannot have rest parameter.
╭─[typescript/tests/cases/compiler/accessorWithRestParam.ts:3:18]
2 │ set X(...v) { }
3 │ static set X(...v2) { }
Expand Down Expand Up @@ -22529,7 +22529,7 @@ Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/statements/Va
3 │ }
╰────

× A 'set' accessor cannot have rest parameter.
× TS(1053): A 'set' accessor cannot have rest parameter.
╭─[typescript/tests/cases/conformance/parser/ecmascript5/MemberAccessorDeclarations/parserMemberAccessorDeclaration18.ts:2:12]
1 │ class C {
2 │ set Foo(...a) { }
Expand Down
Loading