Skip to content

chore(formatter): support --diff in example#18443

Merged
graphite-app[bot] merged 1 commit intomainfrom
01-23-chore_formatter_support_--diff_in_example
Jan 26, 2026
Merged

chore(formatter): support --diff in example#18443
graphite-app[bot] merged 1 commit intomainfrom
01-23-chore_formatter_support_--diff_in_example

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Jan 23, 2026

Pass --diff to compare the formatted code to the input, which is very useful when you copy the Prettier output here to check if it is formatted as expected or for idempotency testing.

@github-actions github-actions bot added A-formatter Area - Formatter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Jan 23, 2026
Copy link
Member Author

Dunqing commented Jan 23, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 23, 2026

Merging this PR will not alter performance

✅ 42 untouched benchmarks
⏩ 3 skipped benchmarks1


Comparing 01-23-chore_formatter_support_--diff_in_example (0eb984a) with 01-23-chore_tasks_unify_printing_differences_for_mismatch_code (9cf4b23)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@Dunqing Dunqing marked this pull request as ready for review January 23, 2026 10:17
@Dunqing Dunqing requested a review from leaysgur January 23, 2026 10:17
@Dunqing Dunqing force-pushed the 01-23-chore_formatter_support_--diff_in_example branch from 0d3fc4a to 0eb984a Compare January 23, 2026 10:17
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jan 23, 2026
Copy link
Member

Boshen commented Jan 23, 2026

Merge activity

  • Jan 23, 11:54 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 25, 7:02 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 26, 5:35 AM UTC: Boshen added this pull request to the Graphite merge queue.
  • Jan 26, 5:41 AM UTC: Merged by the Graphite merge queue.

@Boshen Boshen added 0-merge Merge with Graphite Merge Queue and removed 0-merge Merge with Graphite Merge Queue labels Jan 25, 2026
@Dunqing Dunqing force-pushed the 01-23-chore_formatter_support_--diff_in_example branch from 0eb984a to 86069f9 Compare January 26, 2026 01:35
@Dunqing Dunqing force-pushed the 01-23-chore_tasks_unify_printing_differences_for_mismatch_code branch from 9cf4b23 to d7f6b44 Compare January 26, 2026 01:35
@graphite-app graphite-app bot force-pushed the 01-23-chore_tasks_unify_printing_differences_for_mismatch_code branch from d7f6b44 to abf442f Compare January 26, 2026 01:48
@graphite-app graphite-app bot requested a review from overlookmotel as a code owner January 26, 2026 01:48
@graphite-app graphite-app bot force-pushed the 01-23-chore_tasks_unify_printing_differences_for_mismatch_code branch from abf442f to d12914f Compare January 26, 2026 01:49
@graphite-app graphite-app bot force-pushed the 01-23-chore_formatter_support_--diff_in_example branch from 86069f9 to 8286311 Compare January 26, 2026 01:49
@Dunqing Dunqing force-pushed the 01-23-chore_formatter_support_--diff_in_example branch from 8286311 to da3368a Compare January 26, 2026 02:09
@Dunqing Dunqing force-pushed the 01-23-chore_tasks_unify_printing_differences_for_mismatch_code branch from d12914f to e4dc98d Compare January 26, 2026 02:09
@leaysgur leaysgur changed the base branch from 01-23-chore_tasks_unify_printing_differences_for_mismatch_code to graphite-base/18443 January 26, 2026 05:08
@graphite-app graphite-app bot force-pushed the 01-23-chore_formatter_support_--diff_in_example branch from da3368a to a0447a5 Compare January 26, 2026 05:24
@graphite-app graphite-app bot force-pushed the graphite-base/18443 branch from e4dc98d to 4d97ba3 Compare January 26, 2026 05:24
@graphite-app graphite-app bot changed the base branch from graphite-base/18443 to main January 26, 2026 05:24
@graphite-app graphite-app bot force-pushed the 01-23-chore_formatter_support_--diff_in_example branch from a0447a5 to 956b9fd Compare January 26, 2026 05:25
Copilot AI review requested due to automatic review settings January 26, 2026 05:28
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Pass `--diff` to compare the formatted code to the input, which is very useful when you copy the Prettier output here to check if it is formatted as expected or for idempotency testing.
@graphite-app graphite-app bot force-pushed the 01-23-chore_formatter_support_--diff_in_example branch from 322b8c2 to 233dda6 Compare January 26, 2026 05:35
@graphite-app graphite-app bot merged commit 233dda6 into main Jan 26, 2026
21 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jan 26, 2026
@graphite-app graphite-app bot deleted the 01-23-chore_formatter_support_--diff_in_example branch January 26, 2026 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-formatter Area - Formatter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants