Skip to content

chore(prettier_conformance): improve the information that is shown in filter #18439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Jan 26, 2026
Merged

chore(prettier_conformance): improve the information that is shown in filter #18439

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 6 additions & 27 deletions tasks/prettier_conformance/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,8 +223,8 @@ impl TestRunner {

let mut failed_test_files = vec![];
for path in test_files {
if self.options.debug {
println!("{}", path.to_string_lossy());
if self.options.debug || has_debug_filter {
println!("Test: {}", path.to_string_lossy());
}
// Single source text is used for multiple options
let source_text = std::fs::read_to_string(path).unwrap();
Expand Down Expand Up @@ -266,16 +266,6 @@ impl TestRunner {
}

if has_debug_filter {
// let print_with_border = |title: &str| {
// let w = format_options.line_width.value() as usize;
// println!("--- {title} {}", "-".repeat(w - title.len() - 5));
// };

println!(
"{} Test: {}",
if result { "✨" } else { "💥" },
path.strip_prefix(fixtures_root()).unwrap().to_string_lossy(),
);
println!(
"Options: {{ {} }}",
snapshot_options
Expand All @@ -286,21 +276,10 @@ impl TestRunner {
.join(", ")
);

if !result {
// print_with_border("Input");
// println!("{source_text}");
// print_with_border(&format!(
// "PrettierOutput: {}LoC",
// expected.lines().count()
// ));
// println!("{expected}");
// print_with_border(&format!("OxcOutput: {}LoC", actual.lines().count()));
// println!("{actual}");
// print_with_border("Diff");
println!(
"{}",
path.strip_prefix(fixtures_root()).unwrap().to_string_lossy()
);
if result {
println!("Passed ✅");
} else {
println!("Failed ❌");
oxc_tasks_common::print_text_diff(&diff);
}
println!();
Expand Down
Loading