fix(linter/plugins): fix identifying "use strict" directives in scope analysis

apps/oxlint/conformance/snapshot.md

@@ -7,8 +7,8 @@
 | Status            | Count | %      |
 | ----------------- | ----- | ------ |
 | Total rules       |   292 | 100.0% |
-| Fully passing     |   291 |  99.7% |
-| Partially passing |     1 |   0.3% |
+| Fully passing     |   292 | 100.0% |
+| Partially passing |     0 |   0.0% |
 | Fully failing     |     0 |   0.0% |
 | Load errors       |     0 |   0.0% |
 | No tests run      |     0 |   0.0% |
@@ -18,8 +18,8 @@
 | Status      | Count | %      |
 | ----------- | ----- | ------ |
 | Total tests | 33090 | 100.0% |
-| Passing     | 32807 |  99.1% |
-| Failing     |     1 |   0.0% |
+| Passing     | 32808 |  99.1% |
+| Failing     |     0 |   0.0% |
 | Skipped     |   282 |   0.9% |
 
 ## Fully Passing Rules
@@ -137,6 +137,7 @@
 - `no-empty-static-block` (10 tests)
 - `no-empty` (35 tests)
 - `no-eq-null` (5 tests)
+- `no-eval` (101 tests) (1 skipped)
 - `no-ex-assign` (8 tests)
 - `no-extend-native` (40 tests)
 - `no-extra-bind` (43 tests)
@@ -318,44 +319,4 @@
 
 ## Rules with Failures
 
-- `no-eval` - 100 / 101 (99.0%)
-
-## Rules with Failures Detail
-
-### `no-eval`
-
-Pass: 99 / 101 (98.0%)
-Fail: 1 / 101 (1.0%)
-Skip: 1 / 101 (1.0%)
-
-#### no-eval > invalid
-
-```js
-function foo() { ('use strict'); this.eval; }
-```
-
-```json
-{
-  "languageOptions": {
-    "ecmaVersion": 5,
-    "sourceType": "script"
-  },
-  "errors": [
-    {
-      "messageId": "unexpected",
-      "column": 39,
-      "endColumn": 43
-    }
-  ]
-}
-```
-
-AssertionError [ERR_ASSERTION]: Should have 1 error but had 0: []
-
-0 !== 1
-
-    at assertErrorCountIsCorrect (apps/oxlint/dist/index.js)
-    at assertInvalidTestCasePasses (apps/oxlint/dist/index.js)
-    at runInvalidTestCase (apps/oxlint/dist/index.js)
-    at apps/oxlint/dist/index.js
-
+No rules with failures

patches/@typescript-eslint__scope-manager.patch

@@ -0,0 +1,31 @@
+diff --git a/dist/scope/ScopeBase.js b/dist/scope/ScopeBase.js
+index 5e07a7c3fb4670b2ce4fa405798d2f27c0084fef..b90f28311dc4a464243a017a51aeffc0e7409e21 100644
+--- a/dist/scope/ScopeBase.js
++++ b/dist/scope/ScopeBase.js
+@@ -59,23 +59,15 @@ function isStrictScope(scope, block, isMethodDefinition) {
+         return false;
+     }
+     // Search 'use strict' directive.
++    // This check has been modified from @typescript-eslint/scope-manager's original code.
++    // See: https://github.com/typescript-eslint/typescript-eslint/issues/11993
+     for (const stmt of body.body) {
+-        if (stmt.type !== types_1.AST_NODE_TYPES.ExpressionStatement) {
++        if (stmt.type !== types_1.AST_NODE_TYPES.ExpressionStatement || stmt.directive == null) {
+             break;
+         }
+         if (stmt.directive === 'use strict') {
+             return true;
+         }
+-        const expr = stmt.expression;
+-        if (expr.type !== types_1.AST_NODE_TYPES.Literal) {
+-            break;
+-        }
+-        if (expr.raw === '"use strict"' || expr.raw === "'use strict'") {
+-            return true;
+-        }
+-        if (expr.value === 'use strict') {
+-            return true;
+-        }
+     }
+     return false;
+ }

pnpm-workspace.yaml

@@ -28,6 +28,7 @@ onlyBuiltDependencies:
   - esbuild@0.25.11
 
 patchedDependencies:
+  "@typescript-eslint/scope-manager": patches/@typescript-eslint__scope-manager.patch
   prettier-plugin-tailwindcss@0.7.2: patches/prettier-plugin-tailwindcss@0.7.2.patch
 
 verifyDepsBeforeRun: install