Skip to content

perf(linter/exhaustive-deps): simplify the logic of checking if the identifier it is a dependency of hook #18350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Jan 22, 2026
Merged

perf(linter/exhaustive-deps): simplify the logic of checking if the identifier it is a dependency of hook #18350

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
75 changes: 26 additions & 49 deletions crates/oxc_linter/src/rules/react/exhaustive_deps.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -922,51 +922,39 @@ fn is_identifier_a_dependency_impl<'a>(
component_scope_id: ScopeId,
visited: &mut FxHashSet<SymbolId>,
) -> bool {
// if it is a global e.g. `console` or `window`, then it's not a dependency
if ctx.scoping().root_unresolved_references().contains_key(ident_name.as_str()) {
return false;
}

let Some(declaration) = get_declaration_from_reference_id(ident_reference_id, ctx) else {
// No declaration means it's a global variable, e.g. `console` or `window`,
// which are not dependencies
return false;
};

let semantic = ctx.semantic();
let scopes = semantic.scoping();

// if the variable was declared in the root scope, then it's not a dependency
if declaration.scope_id() == scopes.root_scope_id() {
return false;
}

// Variable was declared outside the component scope
// ```tsx
// const id = crypto.randomUUID();
// function MyComponent() {
// useEffect(() => {
// console.log(id);
// }, []);
// return <div />;
// }
// ```
if scopes
.scope_ancestors(component_scope_id)
.skip(1)
.any(|parent| parent == declaration.scope_id())
{
// As long as the variable is not declared inside the component, it is not a dependency.
if declaration.scope_id() != component_scope_id {
// 1. Variable was declared outside the component scope
// ```tsx
// const id = crypto.randomUUID();
// function MyComponent() {
// useEffect(() => {
// console.log(id);
// }, []);
// return <div />;
// }
// ```
//
// 2. Variable was declared inside a child scope
// ```tsx
// function MyComponent() {
// useEffect(() => {
// const id = crypto.randomUUID();
// console.log(id);
// }, []);
// return <div />;
// }
// ```
return false;
}

// Variable was declared inside a child scope
// ```tsx
// function MyComponent() {
// useEffect(() => {
// const id = crypto.randomUUID();
// console.log(id);
// }, []);
// return <div />;
// }
if scopes.iter_all_scope_child_ids(component_scope_id).any(|id| id == declaration.scope_id()) {
if declaration.span().contains_inclusive(ident_span) {
return false;
}

Expand All @@ -981,17 +969,6 @@ fn is_identifier_a_dependency_impl<'a>(
return false;
}

// Using a declaration recursively is ok
// ```tsx
// function MyComponent() {
// const recursive = useCallback((n: number): number => (n <= 0 ? 0 : n + recursive(n - 1)), []);
// return recursive
// }
// ```
if declaration.span().contains_inclusive(ident_span) {
return false;
}

true
}

Expand Down
Loading