Skip to content

fix(linter/plugins): allow line number passed to report to be 1 over line count #18341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Jan 21, 2026
Merged

fix(linter/plugins): allow line number passed to report to be 1 over line count #18341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 5 additions & 46 deletions apps/oxlint/conformance/snapshot.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
| Status | Count | % |
| ----------------- | ----- | ------ |
| Total rules | 292 | 100.0% |
| Fully passing | 283 | 96.9% |
| Partially passing | 9 | 3.1% |
| Fully passing | 284 | 97.3% |
| Partially passing | 8 | 2.7% |
| Fully failing | 0 | 0.0% |
| Load errors | 0 | 0.0% |
| No tests run | 0 | 0.0% |
Expand All @@ -18,8 +18,8 @@
| Status | Count | % |
| ----------- | ----- | ------ |
| Total tests | 33090 | 100.0% |
| Passing | 32798 | 99.1% |
| Failing | 21 | 0.1% |
| Passing | 32799 | 99.1% |
| Failing | 20 | 0.1% |
| Skipped | 271 | 0.8% |

## Fully Passing Rules
Expand Down Expand Up @@ -169,6 +169,7 @@
- `no-multi-assign` (31 tests)
- `no-multi-spaces` (130 tests)
- `no-multi-str` (7 tests)
- `no-multiple-empty-lines` (46 tests)
- `no-native-reassign` (18 tests) (3 skipped)
- `no-negated-condition` (19 tests)
- `no-negated-in-lhs` (3 tests)
Expand Down Expand Up @@ -314,7 +315,6 @@
- `no-extra-parens` - 1068 / 1072 (99.6%)
- `no-invalid-this` - 558 / 562 (99.3%)
- `no-irregular-whitespace` - 279 / 280 (99.6%)
- `no-multiple-empty-lines` - 45 / 46 (97.8%)
- `no-unused-expressions` - 120 / 124 (96.8%)
- `no-use-before-define` - 346 / 347 (99.7%)
- `prefer-object-spread` - 86 / 87 (98.9%)
Expand Down Expand Up @@ -706,47 +706,6 @@ AssertionError [ERR_ASSERTION]: Should have no errors but had 1: [
at apps/oxlint/dist/index.js


### `no-multiple-empty-lines`

Pass: 45 / 46 (97.8%)
Fail: 1 / 46 (2.2%)
Skip: 0 / 46 (0.0%)

#### no-multiple-empty-lines > invalid

```js
foo

```

```json
{
"output": "foo\n",
"options": [
{
"max": 1,
"maxEOF": 0
}
],
"errors": [
{
"messageId": "blankEndOfFile",
"data": {
"max": 0
},
"column": 1
}
]
}
```

RangeError: Line number out of range (line 3 requested). Line numbers should be 1-based, and less than or equal to number of lines in file (2).
at getOffsetFromLineColumn (apps/oxlint/dist/lint.js)
at report (apps/oxlint/dist/lint.js)
at Object.report (apps/oxlint/dist/lint.js)
at apps/oxlint/conformance/submodules/eslint/lib/rules/no-multiple-empty-lines.js:157:17


### `no-unused-expressions`

Pass: 120 / 124 (96.8%)
Expand Down
3 changes: 3 additions & 0 deletions apps/oxlint/src-js/plugins/report.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,6 +291,9 @@ function getOffsetFromLineColumn(lineCol: LineColumn): number {
debugAssertLinesIsInitialized();

if (line <= 0 || line > lineStartIndices.length) {
// Allow `line` to be 1 greater than the number of lines in the file if `column` is 0
if (line === lineStartIndices.length + 1 && column === 0) return sourceText.length;

throw new RangeError(
`Line number out of range (line ${line} requested). ` +
`Line numbers should be 1-based, and less than or equal to number of lines in file (${lineStartIndices.length}).`,
Expand Down
Loading