fix(linter): fix rulegen tool broken after #18076#18338
Merged
graphite-app[bot] merged 1 commit intomainfrom Jan 21, 2026
Merged
fix(linter): fix rulegen tool broken after #18076#18338graphite-app[bot] merged 1 commit intomainfrom
graphite-app[bot] merged 1 commit intomainfrom
Conversation
Member
Author
Merge activity
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the rulegen tool that was broken after #18076 removed the declare_all_lint_rules! macro. The fix addresses two issues: removes obsolete macro handling code and fixes rule name matching to respect the specified plugin.
Changes:
- Removed obsolete
declare_all_lint_rules!macro handling fromadd_rules_entryfunction - Fixed
find_unsupported_ruleto use exact plugin prefix matching instead of substring matching - Added
get_unsupported_rule_prefixhelper function to map RuleKind to correct prefixes
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
## Summary - Remove obsolete `declare_all_lint_rules!` macro handling from `add_rules_entry` - the macro was removed in #18076 - Fix `find_unsupported_rule` to respect the specified plugin instead of matching any plugin's rule with the same name ## Test plan - [x] `cargo test -p rulegen` passes - [x] `cargo run -p rulegen dot-notation` now correctly creates `eslint/dot-notation` instead of failing with `vue/dot-notation` unsupported error Closes #18322 🤖 Generated with [Claude Code](https://claude.ai/claude-code)
graphite-app
bot
force-pushed
the
fix-rulegen-broken
branch
from
fa13bf6 to
04a2871
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
declare_all_lint_rules!macro handling fromadd_rules_entry- the macro was removed in refactor(linter): replacedeclare_all_lint_rules!macro with codegen #18076find_unsupported_ruleto respect the specified plugin instead of matching any plugin's rule with the same nameTest plan
cargo test -p rulegenpassescargo run -p rulegen dot-notationnow correctly createseslint/dot-notationinstead of failing withvue/dot-notationunsupported errorCloses #18322
🤖 Generated with Claude Code