Skip to content

perf(semantic): skip parent lookup for function declarations in Function::bind #18293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Jan 21, 2026
+7 −3
Merged

perf(semantic): skip parent lookup for function declarations in Function::bind #18293

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions crates/oxc_semantic/src/binder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,8 @@ impl<'a> Binder<'a> for Class<'a> {

impl<'a> Binder<'a> for Function<'a> {
fn bind(&self, builder: &mut SemanticBuilder) {
let is_declaration = self.is_declaration();

let includes = if self.declare {
SymbolFlags::Function | SymbolFlags::Ambient
} else {
Expand All @@ -144,8 +146,7 @@ impl<'a> Binder<'a> for Function<'a> {
if let Some(ident) = &self.id {
let excludes = if builder.source_type.is_typescript() {
SymbolFlags::FunctionExcludes
} else if self.is_declaration() && is_function_decl_part_of_if_statement(self, builder)
{
} else if is_declaration && is_function_decl_part_of_if_statement(self, builder) {
SymbolFlags::empty()
} else {
// `var x; function x() {}` is valid in non-strict mode, but `TypeScript`
Expand All @@ -164,7 +165,10 @@ impl<'a> Binder<'a> for Function<'a> {
}

// Bind scope flags: GetAccessor | SetAccessor
if let AstKind::ObjectProperty(prop) = builder.nodes.parent_kind(builder.current_node_id) {
if !is_declaration
&& let AstKind::ObjectProperty(prop) =
builder.nodes.parent_kind(builder.current_node_id)
{
// Do not bind scope flags when function is inside of the object property key:
//
// { set [function() {}](val) {} }
Expand Down
Loading