refactor(semantic): simplify checking if function is part of if statement

[overlookmotel]

is_function_part_of_if_statement had some convoluted code to check if a Function is the consequent or alternate of an IfStatement.

Simplify it by checking if the Function is a function declaration, then just a check for whether the parent node is an IfStatement.

Rationale is:

• If a Function is a declaration, it can only be the consequent or alternate of an IfStatement. It can't be the test, because that's an expression not a declaration. So if a function declaration's parent is an IfStatement, it's definitely either the consequent or alternate.
• If a Function is an expression, it's parent can't be consequent or alternate of an IfStatement because the function would need to be wrapped in some other node e.g. ExpressionStatement (and then IfStatement wouldn't be the function's parent).

Also add a comment explaining why we do the check for strict/sloppy mode too.

[overlookmotel]

• refactor(semantic): move code into if block #18294 : 2 dependent PRs (#18295 , #18296 )
• perf(semantic): skip parent lookup for function declarations in Function::bind #18293
• perf(semantic): move check for function declaration out of is_function_part_of_if_statement #18292
• perf(semantic): skip checking redeclarations for function expressions #18291
• refactor(semantic): simplify checking if function is part of if statement #18290 👈 (View in Graphite)
• test(semantic): add test cases for function redeclaration check #18288
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Performance Report

Merging this PR will not alter performance

_{Comparing om/01-19-refactor_semantic_simplify_checking_if_function_is_part_of_if_statement (3f602f0) with main (6803adf)¹}

Summary

✅ 42 untouched benchmarks
⏩ 3 skipped benchmarks²

Footnotes

1. No successful run was found on om/01-20-test_semantic_add_test_cases_for_function_redeclaration_check (64ed030) during the generation of this report, so main (6803adf) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

2. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[Copilot]

Pull request overview

This PR refactors the is_function_part_of_if_statement function to use a simpler and more straightforward approach for checking if a function declaration is the consequent or alternate of an IfStatement. The refactoring removes pointer equality checks and leverages the fact that function declarations can only appear in specific positions within an IfStatement.

Changes:

• Simplified logic by first checking if the function is a declaration, then checking parent node kind
• Removed std::ptr import and pointer equality comparisons
• Added clarifying comments explaining the logic and strict mode optimization

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[graphite-app]

Merge activity

• Jan 20, 2:02 PM UTC: Boshen added this pull request to the Graphite merge queue.
• Jan 21, 1:08 AM UTC: Dunqing added this pull request to the Graphite merge queue.
• Jan 21, 1:15 AM UTC: Merged by the Graphite merge queue.