test(linter): Add a snapshot test for a complex config#18280
Merged
graphite-app[bot] merged 1 commit intomainfrom Jan 20, 2026
Merged
test(linter): Add a snapshot test for a complex config#18280graphite-app[bot] merged 1 commit intomainfrom
graphite-app[bot] merged 1 commit intomainfrom
Conversation
github-actions
bot
added
A-linter
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a snapshot test to verify that a complex linter configuration file is valid and doesn't produce errors for end-users. The test ensures that the oxlint configuration parser can handle various plugin configurations and rule options correctly.
Changes:
- Added a new snapshot test that validates a complex configuration file
- Created a comprehensive fixture configuration with multiple plugins and diverse rule configurations
- Generated a snapshot capturing the expected successful output
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/oxlint/src/lint.rs | Added test_valid_complex_config() test function following existing test patterns |
| apps/oxlint/fixtures/valid_complex_config/.oxlintrc.json | Created a comprehensive configuration file with various plugins (eslint, import, react, typescript, unicorn, vue, jsdoc) and diverse rule configurations to test parsing capabilities |
| apps/oxlint/src/snapshots/fixtures__valid_complex_config_@oxlint.snap | Generated snapshot file capturing the expected successful output (0 warnings, 0 errors, 22 rules loaded) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
Merge activity
|
Cherry-picked out of #18104 since I want to keep that PR focused on one thing. This adds a snapshot test to ensure that this complex config is valid and doesn't result in any errors for the end-user. This is basically just protecting against us breaking the config validation system by accident, and covers a variety of different config shapes.
graphite-app
bot
force-pushed
the
complex-config-snap
branch
from
c9d062e to
c940111
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked out of #18104 since I want to keep that PR focused on one thing.
This adds a snapshot test to ensure that this complex config is valid and doesn't result in any errors for the end-user. This is basically just protecting against us breaking the config validation system by accident, and covers a variety of different config shapes.