Skip to content

perf(linter/no-redeclare): avoid repeated PHF hashmap lookups #18248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Jan 19, 2026
Merged

perf(linter/no-redeclare): avoid repeated PHF hashmap lookups #18248

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions crates/oxc_linter/src/rules/eslint/no_redeclare.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,11 +74,15 @@ impl Rule for NoRedeclare {
}

fn run_once(&self, ctx: &LintContext) {
// Cache `GLOBALS["builtin"]`, to avoid repeatedly fetching it (hashmap lookup) in the loop below
let builtin_globals = if self.builtin_globals { Some(&GLOBALS["builtin"]) } else { None };

for symbol_id in ctx.scoping().symbol_ids() {
let name = ctx.scoping().symbol_name(symbol_id);
let decl_span = ctx.scoping().symbol_span(symbol_id);
let is_builtin = self.builtin_globals
&& (GLOBALS["builtin"].contains_key(name) || ctx.globals().is_enabled(name));
let is_builtin = builtin_globals.is_some_and(|builtin_globals| {
builtin_globals.contains_key(name) || ctx.globals().is_enabled(name)
});

if is_builtin {
ctx.diagnostic(no_redeclare_as_builtin_in_diagnostic(name, decl_span));
Expand Down
Loading