fix(transformer): use require not import in CommonJS files

[overlookmotel]

Transformer was deciding whether to insert an import statement or require() call depending on source_type.is_script(). That returns false for CommonJS, which was resulting in import statements being inserted in CommonJS files. Fix it by checking source_type.is_module() instead.

[overlookmotel]

• fix(transformer): use require not import in CommonJS files #18226 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Performance Report

Merging this PR will not alter performance

_{Comparing om/01-19-fix_transformer_use_require_not_import_in_commonjs_files (c4fa5d5) with main (8fe1e8e)¹}

Summary

✅ 38 untouched benchmarks
⏩ 7 skipped benchmarks²

Footnotes

1. No successful run was found on main (9a5e3e2) during the generation of this report, so 8fe1e8e was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

2. 7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[Copilot]

Pull request overview

This PR fixes a bug in the transformer where CommonJS files were incorrectly receiving import statements instead of require() calls. The issue was that the code was checking source_type.is_script() which returns false for CommonJS files (they have ModuleKind::CommonJS, not ModuleKind::Script). The fix changes the check to source_type.is_module(), which correctly identifies ES Modules vs everything else (Script, CommonJS).

Changes:

• Swapped the logic in JSX transformer and module imports to use is_module() instead of is_script()
• Removed an unused helper method is_script() from JsxImpl
• Fixed test snapshot showing one additional passing test

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File	Description
crates/oxc_transformer/src/jsx/jsx_impl.rs	Swapped conditional logic from is_script() to is_module() for determining whether to use AutomaticModule vs AutomaticScript bindings, and removed the unused is_script() helper method
crates/oxc_transformer/src/common/module_imports.rs	Fixed the conditional logic to use is_module() instead of is_script() when deciding whether to insert import statements or require statements
tasks/coverage/snapshots/semantic_babel.snap	Updated test snapshot showing one additional passing test and removed the error for a CommonJS file that was incorrectly using import symbol flags

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[overlookmotel]

I think this should fix the problem. Am running monitor-oxc to make sure.

https://github.com/oxc-project/monitor-oxc/actions/runs/21135903246

[overlookmotel]

Yes, the fix works.

[overlookmotel]

Merge activity

• Jan 19, 12:43 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Jan 19, 12:43 PM UTC: overlookmotel added this pull request to the Graphite merge queue.
• Jan 19, 12:54 PM UTC: Merged by the Graphite merge queue.