fix(linter/plugins): rule tester default to module source type in ESLint compat mode#18195
Merged
graphite-app[bot] merged 1 commit intomainfrom Jan 18, 2026
Conversation
github-actions
bot
added
A-linter
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jan 18, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the RuleTester to default to module source type when ESLint compatibility mode is enabled, aligning with ESLint's behavior. Previously, #18124 introduced "unambiguous" parsing (detecting source type from content), which broke several hundred Oxlint JS plugins conformance tests that expected ESLint's default module behavior.
Changes:
- Added default source type of
"module"in ESLint compatibility mode when no explicit source type is provided - Added constant
EMPTY_LANGUAGE_OPTIONSto handle the case when languageOptions is null - Enhanced test coverage with dedicated tests for both default behaviors (with and without eslintCompat)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/oxlint/src-js/package/rule_tester.ts | Added logic to default to "module" source type when eslintCompat is true and no explicit source type is set |
| apps/oxlint/test/rule_tester.test.ts | Refactored and expanded tests to validate both unambiguous parsing (default) and module parsing (ESLint compat mode) behaviors |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
Merge activity
|
…int compat mode (#18195) #18124 altered parsing behavior to default to `script` / `module` source type depending on whether the file contains ESM syntax (e.g. `import` declarations). This broke a several hundred Oxlint JS plugins conformance tests, because ESLint's behavior is to treat files as `module` source type unless directed otherwise. Fix these conformance tests by reverting the "parse based on content" behavior in `RuleTester`, when `eslintCompat` option is enabled.
graphite-app
bot
force-pushed
the
om/01-18-fix_linter_plugins_rule_tester_default_to_module_source_type_in_eslint_compat_mode
branch
from
ca43660 to
8a2dabc
Compare
graphite-app
bot
deleted the
om/01-18-fix_linter_plugins_rule_tester_default_to_module_source_type_in_eslint_compat_mode
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#18124 altered parsing behavior to default to
script/modulesource type depending on whether the file contains ESM syntax (e.g.importdeclarations).This broke a several hundred Oxlint JS plugins conformance tests, because ESLint's behavior is to treat files as
modulesource type unless directed otherwise.Fix these conformance tests by reverting the "parse based on content" behavior in
RuleTester, wheneslintCompatoption is enabled.