Skip to content

fix(linter): vitest/prefer-describe-function-title: Check earlier to avoid false positive #18177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sysix merged 2 commits into from
Jan 20, 2026
Merged

fix(linter): vitest/prefer-describe-function-title: Check earlier to avoid false positive #18177

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f8b033
Check earlier to avoid false positive
JoviDeCroock Jan 18, 2026
da9d7c6
Merge branch 'main' into fix-vitest-describe-rule
Sysix Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 35 additions & 10 deletions crates/oxc_linter/src/rules/vitest/prefer_describe_function_title.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,15 @@ impl PreferDescribeFunctionTitle {
return;
}

let Some(test_vitest_fn) = parse_general_jest_fn_call(call_expr, possible_jest_node, ctx)
else {
return;
};

if test_vitest_fn.kind != JestFnKind::General(JestGeneralFnKind::Describe) {
return;
}

let mut imported_entries =
ctx.module_record().import_entries.iter().map(|entry| entry.local_name.name.as_ref());

Expand Down Expand Up @@ -113,16 +122,6 @@ impl PreferDescribeFunctionTitle {
);
}
Argument::StringLiteral(string_title) => {
let Some(test_vitest_fn) =
parse_general_jest_fn_call(call_expr, possible_jest_node, ctx)
else {
return;
};

if test_vitest_fn.kind != JestFnKind::General(JestGeneralFnKind::Describe) {
return;
}

if !imported_entries.contains(string_title.value.as_ref()) {
return;
}
Expand Down Expand Up @@ -263,6 +262,32 @@ fn test() {
Some(serde_json::json!({ "settings": { "vitest": { "typecheck": true, }, } })),
Some(PathBuf::from("myFunction.test.ts")),
),
(
r#"
import { DocumentBuilder } from "./DocumentBuilder"
describe("Swagger Helper", () => {
beforeEach(() => {
vi.spyOn(DocumentBuilder.prototype, "setTitle")
})
})
Comment on lines +267 to +272
Copy link

Copilot AI Jan 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation in this test case uses mixed tabs and spaces. The raw string literal should use consistent indentation (tabs based on the pattern in other test cases in this file).

Copilot uses AI. Check for mistakes.
"#,
None,
None,
Some(PathBuf::from("swagger.helpers.spec.ts")),
),
(
r#"
import { myFunction } from "./myFunction"
describe("Test Suite", () => {
beforeEach(() => {
vi.spyOn(myFunction, "name")
})
})
Comment on lines +280 to +285
Copy link

Copilot AI Jan 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation in this test case uses mixed tabs and spaces. The raw string literal should use consistent indentation (tabs based on the pattern in other test cases in this file).

Copilot uses AI. Check for mistakes.
"#,
None,
None,
Some(PathBuf::from("myFunction.test.ts")),
),
];

let fail = vec![
Expand Down
Loading