Skip to content

perf(allocator): type-erase RawVec::finish_grow inner function#18175

Merged
graphite-app[bot] merged 1 commit intomainfrom
perf/type-erase-raw-vec-grow
Jan 18, 2026
Merged

perf(allocator): type-erase RawVec::finish_grow inner function#18175
graphite-app[bot] merged 1 commit intomainfrom
perf/type-erase-raw-vec-grow

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Jan 18, 2026

Remove the type parameter T from the inner grow function since it's
immediately cast to u8 anyway. This reduces monomorphization from 37
copies to 1, saving ~5,500 instructions of code bloat.

Co-Authored-By: Claude Opus 4.5 noreply@anthropic.com

@github-actions github-actions bot added the C-performance Category - Solution not expected to change functional behavior, only performance label Jan 18, 2026
Copy link
Member Author

Boshen commented Jan 18, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 18, 2026

Merging this PR will not alter performance

✅ 42 untouched benchmarks
⏩ 3 skipped benchmarks1


Comparing perf/type-erase-raw-vec-grow (ac412b3) with refactor/cleanup-bumpalo-references (8e577de)2

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on refactor/cleanup-bumpalo-references (e041bb8) during the generation of this report, so 702c633 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@Boshen Boshen marked this pull request as ready for review January 18, 2026 08:46
@Boshen Boshen requested a review from overlookmotel as a code owner January 18, 2026 08:46
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jan 18, 2026
Copy link
Member Author

Boshen commented Jan 18, 2026

Merge activity

Remove the type parameter T from the inner grow function since it's
immediately cast to u8 anyway. This reduces monomorphization from 37
copies to 1, saving ~5,500 instructions of code bloat.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@graphite-app graphite-app bot force-pushed the refactor/cleanup-bumpalo-references branch from e041bb8 to 08da7bd Compare January 18, 2026 08:47
@graphite-app graphite-app bot force-pushed the perf/type-erase-raw-vec-grow branch from ac412b3 to 8da684e Compare January 18, 2026 08:48
Base automatically changed from refactor/cleanup-bumpalo-references to main January 18, 2026 08:53
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jan 18, 2026
@graphite-app graphite-app bot merged commit 8da684e into main Jan 18, 2026
23 checks passed
@graphite-app graphite-app bot deleted the perf/type-erase-raw-vec-grow branch January 18, 2026 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant