Skip to content

Comments

fix(linter): Move typescript/prefer-optional-chain to nursery for now.#18147

Merged
graphite-app[bot] merged 1 commit intomainfrom
babysit
Jan 19, 2026
Merged

fix(linter): Move typescript/prefer-optional-chain to nursery for now.#18147
graphite-app[bot] merged 1 commit intomainfrom
babysit

Conversation

@connorshea
Copy link
Member

The rule is quite complex, so we want to make sure we get it right before we move it to wider usage. You can still use it, but it may have some edge-cases where it behaves incorrectly still.

e.g. #18110, #17968, #18106

@connorshea connorshea requested a review from camc314 as a code owner January 17, 2026 21:32
Copilot AI review requested due to automatic review settings January 17, 2026 21:32
@github-actions github-actions bot added A-linter Area - Linter C-bug Category - Bug labels Jan 17, 2026
@connorshea connorshea requested a review from camchenry January 17, 2026 21:32
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR moves the typescript/prefer-optional-chain linter rule from the "style" category to the "nursery" category to allow for further refinement and edge-case testing before promoting it to wider usage.

Changes:

  • Added documentation explaining the rule's nursery status and the complexity of the autofix logic
  • Changed the rule category from "style" to "nursery" with an explanatory comment

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 17, 2026

Merging this PR will not alter performance

✅ 4 untouched benchmarks
⏩ 41 skipped benchmarks1


Comparing babysit (303bab3) with main (85a846c)

Open in CodSpeed

Footnotes

  1. 41 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@connorshea connorshea requested a review from Boshen January 18, 2026 16:26
@connorshea connorshea added the 0-merge Merge with Graphite Merge Queue label Jan 19, 2026
Copy link
Member Author

connorshea commented Jan 19, 2026

Merge activity

#18147)

The rule is quite complex, so we want to make sure we get it right before we move it to wider usage. You can still use it, but it may have some edge-cases where it behaves incorrectly still.

e.g. #18110, #17968, #18106
@graphite-app graphite-app bot merged commit a0b3721 into main Jan 19, 2026
21 checks passed
@graphite-app graphite-app bot deleted the babysit branch January 19, 2026 01:13
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jan 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants