fix(linter): Move typescript/prefer-optional-chain to nursery for now.#18147
Merged
graphite-app[bot] merged 1 commit intomainfrom Jan 19, 2026
Merged
fix(linter): Move typescript/prefer-optional-chain to nursery for now.#18147graphite-app[bot] merged 1 commit intomainfrom
graphite-app[bot] merged 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR moves the typescript/prefer-optional-chain linter rule from the "style" category to the "nursery" category to allow for further refinement and edge-case testing before promoting it to wider usage.
Changes:
- Added documentation explaining the rule's nursery status and the complexity of the autofix logic
- Changed the rule category from "style" to "nursery" with an explanatory comment
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
camchenry
approved these changes
Jan 17, 2026
Merging this PR will not alter performance
Comparing Footnotes
|
camc314
approved these changes
Jan 19, 2026
Member
Author
Merge activity
|
303bab3 to
a0b3721
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rule is quite complex, so we want to make sure we get it right before we move it to wider usage. You can still use it, but it may have some edge-cases where it behaves incorrectly still.
e.g. #18110, #17968, #18106