feat(regular_expression): add Unicode 17.0 script properties#18140
Merged
graphite-app[bot] merged 1 commit intomainfrom Jan 17, 2026
Merged
feat(regular_expression): add Unicode 17.0 script properties#18140graphite-app[bot] merged 1 commit intomainfrom
graphite-app[bot] merged 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for 4 new Unicode 17.0 script properties to the regular expression parser. The implementation enables recognition of these scripts in regex Unicode property escapes, fixing test failures in the Test262 suite.
Changes:
- Added 4 new Unicode 17.0 script properties:
Beria_Erfe(Berf),Sidetic(Sidt),Tai_Yo(Tayo), andTolong_Siki(Tols) - Improved test coverage with 8 additional parser_test262 tests passing, 8 semantic_test262 tests passing, and 1 minifier_node_compat test passing
Reviewed changes
Copilot reviewed 1 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/oxc_regular_expression/src/parser/pattern_parser/unicode_property.rs | Added 4 new Unicode 17.0 script properties to SC_PROPERTY_VALUES in alphabetically correct positions |
| tasks/coverage/snapshots/parser_test262.snap | Updated to reflect 8 additional passing tests (46547 → 46555) |
| tasks/coverage/snapshots/semantic_test262.snap | Updated to reflect 8 additional passing tests (44911 → 44919) |
| tasks/coverage/snapshots/minifier_node_compat.snap | Updated to reflect 1 additional passing test (930 → 931) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
Footnotes
|
Member
Author
Merge activity
|
## Summary Add support for 4 new scripts introduced in Unicode 17.0: - `Beria_Erfe` (`Berf`) - `Sidetic` (`Sidt`) - `Tai_Yo` (`Tayo`) - `Tolong_Siki` (`Tols`) ## Test plan - [x] 8 parser_test262 tests now pass (from 46547 → 46555 positive passed) - [x] 1 minifier_node_compat test now passes (from 930 → 931 positive passed) - [x] 8 semantic_test262 tests now pass (from 44911 → 44919 positive passed) - [x] `cargo test -p oxc_regular_expression` passes 🤖 Generated with [Claude Code](https://claude.ai/code)
graphite-app
bot
force-pushed
the
feat/unicode-17-script-properties
branch
from
bab8c79 to
830b757
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add support for 4 new scripts introduced in Unicode 17.0:
Beria_Erfe(Berf)Sidetic(Sidt)Tai_Yo(Tayo)Tolong_Siki(Tols)Test plan
cargo test -p oxc_regular_expressionpasses🤖 Generated with Claude Code